From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Amos Kong <akong@redhat.com>,
linux-pci@vger.kernel.org, seabios@seabios.org,
qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl,
kevin@koconnor.net
Subject: Re: [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables
Date: Thu, 10 May 2012 20:03:47 +0300 [thread overview]
Message-ID: <20120510170345.GC14647@redhat.com> (raw)
In-Reply-To: <4FABF1DD.7090101@gmail.com>
On Fri, May 11, 2012 at 12:50:37AM +0800, Jiang Liu wrote:
> On 05/09/2012 09:47 PM, Alex Williamson wrote:
> >> ---
> >> src/ssdt-pcihp.dsl | 17
> >> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> >> 2 files changed, 8781 insertions(+), 105 deletions(-)
> >>
> >> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
> >> index 4b435b8..2a3c326 100644
> >> --- a/src/ssdt-pcihp.dsl
> >> +++ b/src/ssdt-pcihp.dsl
> >> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
> >> // at runtime, if the slot is detected to not support hotplug.
> >> // Extract the offset of the address dword and the
> >> // _EJ0 name to allow this patching.
> >> -#define hotplug_slot(slot) \
> >> - Device (S##slot) { \
> >> +#define hotplug_func(slot, fn) \
> >> + Device (S##slot##fn) { \
> >> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \
> >> - Name (_ADR, 0x##slot##0000) \
> >
> > I would have guessed it to be sufficient to change _ADR to
> > 0x##slot##ffff, does that not work? Thanks,
> >
> > Alex
> Currently Linux acpiphp driver doesn't support that yet.
>
> --gerry
If memory serves neither does windows.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: linux-pci@vger.kernel.org, seabios@seabios.org,
qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl,
Alex Williamson <alex.williamson@redhat.com>,
kevin@koconnor.net, Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables
Date: Thu, 10 May 2012 20:03:47 +0300 [thread overview]
Message-ID: <20120510170345.GC14647@redhat.com> (raw)
In-Reply-To: <4FABF1DD.7090101@gmail.com>
On Fri, May 11, 2012 at 12:50:37AM +0800, Jiang Liu wrote:
> On 05/09/2012 09:47 PM, Alex Williamson wrote:
> >> ---
> >> src/ssdt-pcihp.dsl | 17
> >> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> >> 2 files changed, 8781 insertions(+), 105 deletions(-)
> >>
> >> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
> >> index 4b435b8..2a3c326 100644
> >> --- a/src/ssdt-pcihp.dsl
> >> +++ b/src/ssdt-pcihp.dsl
> >> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
> >> // at runtime, if the slot is detected to not support hotplug.
> >> // Extract the offset of the address dword and the
> >> // _EJ0 name to allow this patching.
> >> -#define hotplug_slot(slot) \
> >> - Device (S##slot) { \
> >> +#define hotplug_func(slot, fn) \
> >> + Device (S##slot##fn) { \
> >> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \
> >> - Name (_ADR, 0x##slot##0000) \
> >
> > I would have guessed it to be sufficient to change _ADR to
> > 0x##slot##ffff, does that not work? Thanks,
> >
> > Alex
> Currently Linux acpiphp driver doesn't support that yet.
>
> --gerry
If memory serves neither does windows.
next prev parent reply other threads:[~2012-05-10 17:04 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 6:53 [SEABIOS PATCH 0/2] fix of hotplug multi-func device Amos Kong
2011-09-19 6:53 ` [SeaBIOS PATCH 1/2] Fix regression of commit 87b533bf Amos Kong
2011-09-19 7:27 ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Amos Kong
2011-09-19 9:57 ` [SeaBIOS] " Gleb Natapov
2011-09-19 10:02 ` Michael S. Tsirkin
2011-09-19 10:12 ` Gleb Natapov
2011-09-19 10:32 ` Gleb Natapov
2011-09-19 12:18 ` [SeaBIOS] " Michael S. Tsirkin
2011-09-19 16:27 ` Marcelo Tosatti
2011-09-19 19:08 ` Michael S. Tsirkin
2011-09-20 10:45 ` [SeaBIOS PATCH v2] " Amos Kong
2011-09-20 11:47 ` Marcelo Tosatti
2011-09-21 1:48 ` Kevin O'Connor
2011-09-21 5:39 ` Amos Kong
2011-09-21 11:09 ` Michael S. Tsirkin
2011-09-21 12:47 ` Kevin O'Connor
2011-09-21 13:14 ` Michael S. Tsirkin
2011-12-06 5:39 ` [SeaBIOS PATCH v3] " Amos Kong
2011-12-06 11:36 ` Michael S. Tsirkin
2011-12-07 0:32 ` Amos Kong
2011-12-14 1:06 ` Kevin O'Connor
2011-12-19 8:45 ` Amos Kong
2012-05-09 7:24 ` [RESEND PATCH v3] hotplug: add " Amos Kong
2012-05-09 7:24 ` [Qemu-devel] " Amos Kong
2012-05-09 7:35 ` Amos Kong
2012-05-09 8:46 ` Michael S. Tsirkin
2012-05-09 8:46 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-09 8:59 ` Amos Kong
2012-05-09 9:53 ` Amos Kong
2012-05-09 13:47 ` Alex Williamson
2012-05-09 13:47 ` [Qemu-devel] " Alex Williamson
2012-05-09 16:08 ` Amos Kong
2012-05-10 16:50 ` Jiang Liu
2012-05-10 16:50 ` [Qemu-devel] " Jiang Liu
2012-05-10 17:03 ` Michael S. Tsirkin [this message]
2012-05-10 17:03 ` Michael S. Tsirkin
2012-05-10 17:17 ` Jiang Liu
2012-05-10 17:17 ` [Qemu-devel] " Jiang Liu
2012-05-10 17:42 ` Michael S. Tsirkin
2012-05-10 17:42 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-10 17:46 ` Jiang Liu
2012-05-10 17:46 ` [Qemu-devel] " Jiang Liu
2012-05-10 23:40 ` Amos Kong
2012-05-10 23:40 ` Amos Kong
2012-05-11 10:14 ` [SeaBIOS] " Gleb Natapov
2012-05-11 10:14 ` [Qemu-devel] " Gleb Natapov
2012-05-11 15:44 ` Jiang Liu
2012-05-11 15:44 ` [Qemu-devel] " Jiang Liu
2012-05-11 17:04 ` Gleb Natapov
2012-05-11 17:04 ` [Qemu-devel] " Gleb Natapov
2011-09-20 10:44 ` [SeaBIOS PATCH] hotplug: Add " Amos Kong
2011-09-20 11:42 ` Marcelo Tosatti
2011-09-20 8:00 ` [SeaBIOS PATCH v2] Fix regression of commit 87b533bf Amos Kong
2011-09-20 23:52 ` Kevin O'Connor
[not found] ` <20110919065347.22802.53640.stgit@t>
[not found] ` <20110919093644.GC4501@redhat.com>
2011-09-19 9:49 ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Michael S. Tsirkin
2011-09-19 10:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510170345.GC14647@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kevin@koconnor.net \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rjw@sisk.pl \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.