All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: jz4740-adc: Fix generic irq chip ack function name.
@ 2011-09-19 14:17 Lars-Peter Clausen
  2011-09-20  8:33 ` Samuel Ortiz
  0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2011-09-19 14:17 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-kernel, Lars-Peter Clausen

In commit 659fb32d1b6("genirq: replace irq_gc_ack() with {set,clr}_bit
variants"), irq_gc_ack was renamed to irq_gc_ack_set_bit. The jz4740-adc
driver still uses the old name which results in a compile error.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
Samuel, it would be good if this fix could make it into 3.1
---
 drivers/mfd/jz4740-adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
index 21131c7..563654c 100644
--- a/drivers/mfd/jz4740-adc.c
+++ b/drivers/mfd/jz4740-adc.c
@@ -273,7 +273,7 @@ static int __devinit jz4740_adc_probe(struct platform_device *pdev)
 	ct->regs.ack = JZ_REG_ADC_STATUS;
 	ct->chip.irq_mask = irq_gc_mask_set_bit;
 	ct->chip.irq_unmask = irq_gc_mask_clr_bit;
-	ct->chip.irq_ack = irq_gc_ack;
+	ct->chip.irq_ack = irq_gc_ack_set_bit;
 
 	irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
 
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: jz4740-adc: Fix generic irq chip ack function name.
  2011-09-19 14:17 [PATCH] mfd: jz4740-adc: Fix generic irq chip ack function name Lars-Peter Clausen
@ 2011-09-20  8:33 ` Samuel Ortiz
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2011-09-20  8:33 UTC (permalink / raw)
  To: Lars-Peter Clausen; +Cc: linux-kernel

Hi Lars,

On Mon, Sep 19, 2011 at 04:17:55PM +0200, Lars-Peter Clausen wrote:
> In commit 659fb32d1b6("genirq: replace irq_gc_ack() with {set,clr}_bit
> variants"), irq_gc_ack was renamed to irq_gc_ack_set_bit. The jz4740-adc
> driver still uses the old name which results in a compile error.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> Samuel, it would be good if this fix could make it into 3.1
I will try to have it merged. For now, it's on my for-next branch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-09-20  8:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-19 14:17 [PATCH] mfd: jz4740-adc: Fix generic irq chip ack function name Lars-Peter Clausen
2011-09-20  8:33 ` Samuel Ortiz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.