From: Baruch Siach <baruch@tkos.co.il>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] include: fb: Add definiton for window positioning
Date: Tue, 20 Sep 2011 17:08:59 +0000 [thread overview]
Message-ID: <20110920170858.GA3827@tarshish> (raw)
In-Reply-To: <CAEC9eQOpwfmRfcxHoiA00xX0a=dxXj1xJDpW14DozGXKXPJ3Xg@mail.gmail.com>
Hi Ajay,
On Tue, Sep 20, 2011 at 08:56:57PM +0530, Ajay kumar wrote:
> Hi Baruch,
> On Tue, Sep 20, 2011 at 4:54 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Hi Ajay,
> >
> > On Tue, Sep 20, 2011 at 11:30:39AM -0400, Ajay Kumar wrote:
> >> This patch adds a data structure definiton to hold framebuffer windows/planes.
> >> An ioctl number is also added to provide user access
> >> to change window position dynamically.
> >
> > [snip]
> >
> >> +/* Window overlaying */
> >> +struct fb_overlay_win_pos {
> >> + __u32 win_pos_x; /* x-offset from LCD(0,0) where window starts */
> >> + __u32 win_pos_y; /* y-offset from LCD(0,0) where window starts */
> >> +};
> >
> > Why not allow negative offsets where the left or upper part of the framebuffer
> > is hidden?
>
> Thanks for pointing it out. Are there drivers which place the overlay
> windows such that some part of the window is hidden from being
> displayed on the screen?
I don't know. However, since this is new userspace ABI which should stay
compatible forever, we should make sure to do it right. Using __s32 instead of
__u32 won't limit us in the future.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{ - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Ajay kumar <ajaynumb@gmail.com>
Cc: FlorianSchandinat@gmx.de, linux-samsung-soc@vger.kernel.org,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
banajit.g@samsung.com, jg1.han@samsung.com, lethal@linux-sh.org,
ben-linux@fluff.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 1/3] include: fb: Add definiton for window positioning structure
Date: Tue, 20 Sep 2011 20:08:59 +0300 [thread overview]
Message-ID: <20110920170858.GA3827@tarshish> (raw)
In-Reply-To: <CAEC9eQOpwfmRfcxHoiA00xX0a=dxXj1xJDpW14DozGXKXPJ3Xg@mail.gmail.com>
Hi Ajay,
On Tue, Sep 20, 2011 at 08:56:57PM +0530, Ajay kumar wrote:
> Hi Baruch,
> On Tue, Sep 20, 2011 at 4:54 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Hi Ajay,
> >
> > On Tue, Sep 20, 2011 at 11:30:39AM -0400, Ajay Kumar wrote:
> >> This patch adds a data structure definiton to hold framebuffer windows/planes.
> >> An ioctl number is also added to provide user access
> >> to change window position dynamically.
> >
> > [snip]
> >
> >> +/* Window overlaying */
> >> +struct fb_overlay_win_pos {
> >> + __u32 win_pos_x; /* x-offset from LCD(0,0) where window starts */
> >> + __u32 win_pos_y; /* y-offset from LCD(0,0) where window starts */
> >> +};
> >
> > Why not allow negative offsets where the left or upper part of the framebuffer
> > is hidden?
>
> Thanks for pointing it out. Are there drivers which place the overlay
> windows such that some part of the window is hidden from being
> displayed on the screen?
I don't know. However, since this is new userspace ABI which should stay
compatible forever, we should make sure to do it right. Using __s32 instead of
__u32 won't limit us in the future.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] include: fb: Add definiton for window positioning structure
Date: Tue, 20 Sep 2011 20:08:59 +0300 [thread overview]
Message-ID: <20110920170858.GA3827@tarshish> (raw)
In-Reply-To: <CAEC9eQOpwfmRfcxHoiA00xX0a=dxXj1xJDpW14DozGXKXPJ3Xg@mail.gmail.com>
Hi Ajay,
On Tue, Sep 20, 2011 at 08:56:57PM +0530, Ajay kumar wrote:
> Hi Baruch,
> On Tue, Sep 20, 2011 at 4:54 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Hi Ajay,
> >
> > On Tue, Sep 20, 2011 at 11:30:39AM -0400, Ajay Kumar wrote:
> >> This patch adds a data structure definiton to hold framebuffer windows/planes.
> >> An ioctl number is also added to provide user access
> >> to change window position dynamically.
> >
> > [snip]
> >
> >> +/* Window overlaying */
> >> +struct fb_overlay_win_pos {
> >> + ? ? __u32 win_pos_x; ? ? ? ?/* x-offset from LCD(0,0) where window starts */
> >> + ? ? __u32 win_pos_y; ? ? ? ?/* y-offset from LCD(0,0) where window starts */
> >> +};
> >
> > Why not allow negative offsets where the left or upper part of the framebuffer
> > is hidden?
>
> Thanks for pointing it out. Are there drivers which place the overlay
> windows such that some part of the window is hidden from being
> displayed on the screen?
I don't know. However, since this is new userspace ABI which should stay
compatible forever, we should make sure to do it right. Using __s32 instead of
__u32 won't limit us in the future.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2011-09-20 17:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 9:28 [PATCH 0/3] FB: Add window positioning support Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
2011-09-20 9:29 ` [PATCH 3/3] video: s3c-fb: Modify s3c-fb driver to support window Ajay Kumar
2011-09-20 15:30 ` [PATCH 3/3] video: s3c-fb: Modify s3c-fb driver to support window positioning Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
2011-09-20 9:29 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
2011-09-20 11:10 ` [PATCH 1/3] include: fb: Add definiton for window positioning Tomi Valkeinen
2011-09-20 11:10 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Tomi Valkeinen
2011-09-20 11:10 ` Tomi Valkeinen
2011-09-20 14:46 ` Ajay kumar
2011-09-20 14:58 ` Ajay kumar
2011-09-20 14:46 ` Ajay kumar
2011-09-20 15:39 ` [PATCH 1/3] include: fb: Add definiton for window positioning Tomi Valkeinen
2011-09-20 15:39 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Tomi Valkeinen
2011-09-20 15:39 ` Tomi Valkeinen
2011-09-20 16:55 ` [PATCH 1/3] include: fb: Add definiton for window positioning Florian Tobias Schandinat
2011-09-20 16:55 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Florian Tobias Schandinat
2011-09-20 16:55 ` Florian Tobias Schandinat
2011-09-20 18:57 ` [PATCH 1/3] include: fb: Add definiton for window positioning Tomi Valkeinen
2011-09-20 18:57 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Tomi Valkeinen
2011-09-20 18:57 ` Tomi Valkeinen
2011-09-21 7:15 ` Ajay kumar
2011-09-21 7:27 ` Ajay kumar
2011-09-21 7:15 ` Ajay kumar
2011-09-20 11:24 ` [PATCH 1/3] include: fb: Add definiton for window positioning Baruch Siach
2011-09-20 11:24 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Baruch Siach
2011-09-20 11:24 ` Baruch Siach
2011-09-20 15:26 ` Ajay kumar
2011-09-20 15:38 ` Ajay kumar
2011-09-20 15:26 ` Ajay kumar
2011-09-20 17:08 ` Baruch Siach [this message]
2011-09-20 17:08 ` Baruch Siach
2011-09-20 17:08 ` Baruch Siach
2011-09-21 6:25 ` [PATCH 1/3] include: fb: Add definiton for window positioning Tomi Valkeinen
2011-09-21 6:25 ` [PATCH 1/3] include: fb: Add definiton for window positioning structure Tomi Valkeinen
2011-09-21 6:25 ` Tomi Valkeinen
2011-09-21 7:18 ` Ajay kumar
2011-09-21 7:30 ` Ajay kumar
2011-09-21 7:18 ` Ajay kumar
2011-09-20 9:29 ` [PATCH 2/3] ARM: SAMSUNG: Embed window positioning data structure in Ajay Kumar
2011-09-20 15:30 ` [PATCH 2/3] ARM: SAMSUNG: Embed window positioning data structure in s3c-fb plat data Ajay Kumar
2011-09-20 15:30 ` Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920170858.GA3827@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.