From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Abhilash K V <abhilash.kv@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
sameo@linux.intel.com, christian.gmeiner@gmail.com,
santosh.shilimkar@ti.com, premi@ti.com,
david.woodhouse@intel.com
Subject: Re: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs
Date: Thu, 22 Sep 2011 15:25:17 -0700 [thread overview]
Message-ID: <20110922222517.GX2937@atomide.com> (raw)
In-Reply-To: <877h50qlne.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110922 14:30]:
> Abhilash K V <abhilash.kv@ti.com> writes:
>
> > The current implementation almost assumes that only
>
> almost? ;)
>
> > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > OMAP processors. This is, however, not true.
> >
> > This patch removes the automatic selection of the PMIC
> > from Kconfig.
> > All currently used PMICs are now added to omap2plus_defconfig;
>
> I don't think adding them to omap2plus_defconfig is right either, as
> those will get stripped out the next time that file is (re)generated.
>
> > any new PMIC that gets supported in future could now be
> > enabled here rather than by changing Kconfig for
> > ARCH_OMAP2PLUS_TYPICAL
>
> IMO, the right fix is to have the board Kconfig entries select the PMIC
> being used on those boards. That is the only solution that will scale,
> and also work when using 'make randconfig'.
Agreed.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs
Date: Thu, 22 Sep 2011 15:25:17 -0700 [thread overview]
Message-ID: <20110922222517.GX2937@atomide.com> (raw)
In-Reply-To: <877h50qlne.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110922 14:30]:
> Abhilash K V <abhilash.kv@ti.com> writes:
>
> > The current implementation almost assumes that only
>
> almost? ;)
>
> > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > OMAP processors. This is, however, not true.
> >
> > This patch removes the automatic selection of the PMIC
> > from Kconfig.
> > All currently used PMICs are now added to omap2plus_defconfig;
>
> I don't think adding them to omap2plus_defconfig is right either, as
> those will get stripped out the next time that file is (re)generated.
>
> > any new PMIC that gets supported in future could now be
> > enabled here rather than by changing Kconfig for
> > ARCH_OMAP2PLUS_TYPICAL
>
> IMO, the right fix is to have the board Kconfig entries select the PMIC
> being used on those boards. That is the only solution that will scale,
> and also work when using 'make randconfig'.
Agreed.
Tony
next prev parent reply other threads:[~2011-09-22 22:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 13:29 [PATCH v3 0/3] AM35x: Adding PM init Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` [PATCH v3 1/3] AM35x: voltage: Basic initialization Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` [PATCH v3 2/3] OMAP3: Add support for TPS65023 (AM35x only) Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 13:29 ` Abhilash K V
2011-09-22 22:04 ` Kevin Hilman
2011-09-22 22:04 ` Kevin Hilman
2011-09-22 22:04 ` Kevin Hilman
2011-09-22 22:25 ` Tony Lindgren [this message]
2011-09-22 22:25 ` Tony Lindgren
2011-09-26 9:58 ` Samuel Ortiz
2011-09-26 9:58 ` Samuel Ortiz
2011-09-22 22:30 ` [PATCH v3 1/3] AM35x: voltage: Basic initialization Kevin Hilman
2011-09-22 22:30 ` Kevin Hilman
2011-09-22 22:30 ` Kevin Hilman
2011-09-23 12:33 ` Koyamangalath, Abhilash
2011-09-23 12:33 ` Koyamangalath, Abhilash
2011-09-23 18:33 ` Kevin Hilman
2011-09-23 18:33 ` Kevin Hilman
2011-09-23 18:33 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922222517.GX2937@atomide.com \
--to=tony@atomide.com \
--cc=abhilash.kv@ti.com \
--cc=christian.gmeiner@gmail.com \
--cc=david.woodhouse@intel.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=premi@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.