From: Greg KH <greg@kroah.com>
To: Timur Tabi <timur@freescale.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-console@vger.kernel.org
Subject: Re: [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c
Date: Thu, 22 Sep 2011 16:06:40 -0700 [thread overview]
Message-ID: <20110922230640.GA16981@kroah.com> (raw)
In-Reply-To: <1316543217-13769-1-git-send-email-timur@freescale.com>
On Tue, Sep 20, 2011 at 01:26:57PM -0500, Timur Tabi wrote:
> The ePAPR hypervisor byte channel console driver only supports one byte
> channel as a console, and the byte channel handle is stored in a global
> variable. It doesn't make any sense to pass that handle as a parameter
> to the console functions, since these functions already have access to the
> global variable.
>
> This change also fixes this compilation warning on a 64-bit kernel:
>
> CC drivers/tty/ehv_bytechan.o
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_write':
> drivers/tty/ehv_bytechan.c:289:24: warning: cast from pointer to integer of different size
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_init':
> drivers/tty/ehv_bytechan.c:355:24: warning: cast to pointer from integer of different size
>
> This warning is because the driver is converting the integer byte channel
> handle to/from the void* 'data' field of struct console. Rather than fix
> the warning, we just eliminate the code altogether.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> drivers/tty/ehv_bytechan.c | 7 ++-----
This patch doesn't apply at all to my tty tree, what was it made
against?
confused,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-console@vger.kernel.org
Subject: Re: [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c
Date: Thu, 22 Sep 2011 16:06:40 -0700 [thread overview]
Message-ID: <20110922230640.GA16981@kroah.com> (raw)
In-Reply-To: <1316543217-13769-1-git-send-email-timur@freescale.com>
On Tue, Sep 20, 2011 at 01:26:57PM -0500, Timur Tabi wrote:
> The ePAPR hypervisor byte channel console driver only supports one byte
> channel as a console, and the byte channel handle is stored in a global
> variable. It doesn't make any sense to pass that handle as a parameter
> to the console functions, since these functions already have access to the
> global variable.
>
> This change also fixes this compilation warning on a 64-bit kernel:
>
> CC drivers/tty/ehv_bytechan.o
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_write':
> drivers/tty/ehv_bytechan.c:289:24: warning: cast from pointer to integer of different size
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_init':
> drivers/tty/ehv_bytechan.c:355:24: warning: cast to pointer from integer of different size
>
> This warning is because the driver is converting the integer byte channel
> handle to/from the void* 'data' field of struct console. Rather than fix
> the warning, we just eliminate the code altogether.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> drivers/tty/ehv_bytechan.c | 7 ++-----
This patch doesn't apply at all to my tty tree, what was it made
against?
confused,
greg k-h
next prev parent reply other threads:[~2011-09-22 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 18:26 [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c Timur Tabi
2011-09-20 18:26 ` Timur Tabi
2011-09-22 23:06 ` Greg KH [this message]
2011-09-22 23:06 ` Greg KH
2011-09-22 23:15 ` Timur Tabi
2011-09-22 23:15 ` Timur Tabi
2011-09-22 23:15 ` Timur Tabi
2011-09-22 23:28 ` Greg KH
2011-09-22 23:28 ` Greg KH
2011-09-23 1:11 ` Tabi Timur-B04825
2011-09-23 1:11 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922230640.GA16981@kroah.com \
--to=greg@kroah.com \
--cc=linux-console@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.