* [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
@ 2011-09-26 6:46 Baruch Siach
2011-09-26 7:17 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2011-09-26 6:46 UTC (permalink / raw)
To: buildroot
The "" string is not equal to the empty string.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
toolchain/toolchain-external/ext-tool.mk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
index a357cb9..3c4ef45 100644
--- a/toolchain/toolchain-external/ext-tool.mk
+++ b/toolchain/toolchain-external/ext-tool.mk
@@ -131,7 +131,7 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
# march/mtune/floating point mode needs to be passed to the external toolchain
# to select the right multilib variant
-ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
+ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),"")
TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
endif
--
1.7.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
2011-09-26 6:46 [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
@ 2011-09-26 7:17 ` Thomas Petazzoni
2011-09-26 7:40 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2011-09-26 7:17 UTC (permalink / raw)
To: buildroot
Le Mon, 26 Sep 2011 09:46:43 +0300,
Baruch Siach <baruch@tkos.co.il> a ?crit :
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),"")
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif
We typically use qstrip for this kind of things:
TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
TOOLCHAIN_EXTERNAL_CFLAGS += $(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
endif
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
2011-09-26 7:17 ` Thomas Petazzoni
@ 2011-09-26 7:40 ` Baruch Siach
0 siblings, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2011-09-26 7:40 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, Sep 26, 2011 at 09:17:30AM +0200, Thomas Petazzoni wrote:
> Le Mon, 26 Sep 2011 09:46:43 +0300,
> Baruch Siach <baruch@tkos.co.il> a ?crit :
>
> > # march/mtune/floating point mode needs to be passed to the external toolchain
> > # to select the right multilib variant
> > -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > +ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),"")
> > TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> > TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> > endif
>
> We typically use qstrip for this kind of things:
>
> TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif
Thanks for the tip. I'll fix and resend.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-26 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-26 6:46 [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-26 7:17 ` Thomas Petazzoni
2011-09-26 7:40 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.