From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
David Vrabel <david.vrabel@citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] xen: Fix selfballooning and ensure it doesn't go too far
Date: Mon, 26 Sep 2011 13:23:07 -0400 [thread overview]
Message-ID: <20110926172307.GA9973@phenom.oracle.com> (raw)
In-Reply-To: <9827a70d-dfb2-4bbc-9df6-207b10c835ac@default>
On Sat, Sep 24, 2011 at 01:58:08PM -0700, Dan Magenheimer wrote:
> [PATCH] xen: Fix selfballooning and ensure it doesn't go too far
>
> The balloon driver's "current_pages" is very different from
> totalram_pages. Self-ballooning needs to be driven by
> the latter. Also, Committed_AS doesn't account for pages
> used by the kernel so enforce a floor for when there
> are little or no user-space threads using memory.
Hey Dan,
..
> + floor_pages = totalreserve_pages +
> + (roundup_pow_of_two(max_pfn) >> 5);
Would it make sense to make the shift be a runtime argument
in case some users report problems with that calculation?
> + /* don't balloon too far, lest OOMs occur... */
> + if (tgt_pages < floor_pages)
> + tgt_pages = floor_pages;
> + balloon_set_new_target(tgt_pages +
> + balloon_stats.current_pages - totalram_pages);
> reset_timer = true;
> }
> #ifdef CONFIG_FRONTSWAP
Otherwise it looks OK to me. Would you like me to queue it up
for 3.1-rc7?
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen: Fix selfballooning and ensure it doesn't go too far
Date: Mon, 26 Sep 2011 13:23:07 -0400 [thread overview]
Message-ID: <20110926172307.GA9973@phenom.oracle.com> (raw)
In-Reply-To: <9827a70d-dfb2-4bbc-9df6-207b10c835ac@default>
On Sat, Sep 24, 2011 at 01:58:08PM -0700, Dan Magenheimer wrote:
> [PATCH] xen: Fix selfballooning and ensure it doesn't go too far
>
> The balloon driver's "current_pages" is very different from
> totalram_pages. Self-ballooning needs to be driven by
> the latter. Also, Committed_AS doesn't account for pages
> used by the kernel so enforce a floor for when there
> are little or no user-space threads using memory.
Hey Dan,
..
> + floor_pages = totalreserve_pages +
> + (roundup_pow_of_two(max_pfn) >> 5);
Would it make sense to make the shift be a runtime argument
in case some users report problems with that calculation?
> + /* don't balloon too far, lest OOMs occur... */
> + if (tgt_pages < floor_pages)
> + tgt_pages = floor_pages;
> + balloon_set_new_target(tgt_pages +
> + balloon_stats.current_pages - totalram_pages);
> reset_timer = true;
> }
> #ifdef CONFIG_FRONTSWAP
Otherwise it looks OK to me. Would you like me to queue it up
for 3.1-rc7?
next prev parent reply other threads:[~2011-09-26 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 20:58 [PATCH] xen: Fix selfballooning and ensure it doesn't go too far Dan Magenheimer
2011-09-26 17:23 ` Konrad Rzeszutek Wilk [this message]
2011-09-26 17:23 ` Konrad Rzeszutek Wilk
2011-09-26 17:24 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926172307.GA9973@phenom.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.