From: Philipp Reisner <philipp.reisner@linbit.com>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*)
Date: Tue, 27 Sep 2011 11:34:03 +0200 [thread overview]
Message-ID: <201109271134.03529.philipp.reisner@linbit.com> (raw)
In-Reply-To: <CAGZ=bq+XQNGEU1HHBEMWdc-hg-B-=eoKNYobUeGrZeeSq41M_A@mail.gmail.com>
Am Freitag, 23. September 2011, 19:38:15 schrieb Kyle Moffett:
> Hi!
>
> On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
>
> <philipp.reisner@linbit.com> wrote:
> > From: Andreas Gruenbacher <agruen@linbit.com>
> >
> > Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> > Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> > ---
> > drivers/block/drbd/drbd_int.h | 45 ----------
> > drivers/block/drbd/drbd_main.c | 44 +++++-----
> > drivers/block/drbd/drbd_receiver.c | 171
> > ++++++++++++++++++------------------ drivers/block/drbd/drbd_worker.c
> > | 2 +-
>
> This commit is kind of borderline too-big for just a one-line commit
> message.
>
> It is admittedly very simple (changing the same pointer math in ~50
> places), but it needs a bit more explanation about why it's helpful or
> necessary.
>
> I *think* it's because the protocol-100 code will use a different-sized
> header, but that needs to be actually explained somewhere.
>
I updated the patch to carry the following commit message:
Author: Andreas Gruenbacher <agruen@linbit.com>
Date: Wed Mar 30 12:54:42 2011 +0200
drbd: Remove headers from on-the-wire data structures (struct p_*)
Prepare the introduction of the protocol 100 headers. The actual protocol
header is removed for the packet declarations. I.e. allow us to use the
packets with different headers.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Reisner <philipp.reisner@linbit.com>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*)
Date: Tue, 27 Sep 2011 11:34:03 +0200 [thread overview]
Message-ID: <201109271134.03529.philipp.reisner@linbit.com> (raw)
In-Reply-To: <CAGZ=bq+XQNGEU1HHBEMWdc-hg-B-=eoKNYobUeGrZeeSq41M_A@mail.gmail.com>
Am Freitag, 23. September 2011, 19:38:15 schrieb Kyle Moffett:
> Hi!
>
> On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
>
> <philipp.reisner@linbit.com> wrote:
> > From: Andreas Gruenbacher <agruen@linbit.com>
> >
> > Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> > Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> > ---
> > drivers/block/drbd/drbd_int.h | 45 ----------
> > drivers/block/drbd/drbd_main.c | 44 +++++-----
> > drivers/block/drbd/drbd_receiver.c | 171
> > ++++++++++++++++++------------------ drivers/block/drbd/drbd_worker.c
> > | 2 +-
>
> This commit is kind of borderline too-big for just a one-line commit
> message.
>
> It is admittedly very simple (changing the same pointer math in ~50
> places), but it needs a bit more explanation about why it's helpful or
> necessary.
>
> I *think* it's because the protocol-100 code will use a different-sized
> header, but that needs to be actually explained somewhere.
>
I updated the patch to carry the following commit message:
Author: Andreas Gruenbacher <agruen@linbit.com>
Date: Wed Mar 30 12:54:42 2011 +0200
drbd: Remove headers from on-the-wire data structures (struct p_*)
Prepare the introduction of the protocol 100 headers. The actual protocol
header is removed for the packet declarations. I.e. allow us to use the
packets with different headers.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
next prev parent reply other threads:[~2011-09-27 9:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 14:31 [Drbd-dev] [RFC 00/10] drbd: part 10 of adding multiple volume support to drbd Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 01/10] drbd: drbd_send_ping(), drbd_send_ping(): Return 0 upon success and an error code otherwise Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 02/10] drbd: Introduce new primitives for sending commands Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 03/10] drbd: Introduce drbd_header_size() Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 04/10] drbd: Replace and remove old primitives Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 17:33 ` [Drbd-dev] " Kyle Moffett
2011-09-23 17:33 ` Kyle Moffett
2011-09-27 9:34 ` [Drbd-dev] " Philipp Reisner
2011-09-27 9:34 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 05/10] drbd: Remove now-unused int_dig_out buffer Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 06/10] drbd: Remove some fixed header size assumptions Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*) Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 17:38 ` [Drbd-dev] " Kyle Moffett
2011-09-23 17:38 ` Kyle Moffett
2011-09-27 9:34 ` Philipp Reisner [this message]
2011-09-27 9:34 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 08/10] drbd: Introduce protocol version 100 headers Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 17:42 ` [Drbd-dev] " Kyle Moffett
2011-09-23 17:42 ` Kyle Moffett
2011-09-27 9:34 ` [Drbd-dev] " Philipp Reisner
2011-09-27 9:34 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 09/10] drbd: Remove volume numbers from struct p_header95 Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 17:28 ` [Drbd-dev] " Kyle Moffett
2011-09-23 17:28 ` Kyle Moffett
2011-09-27 9:34 ` [Drbd-dev] " Philipp Reisner
2011-09-27 9:34 ` Philipp Reisner
2011-09-28 4:26 ` [Drbd-dev] " Kyle Moffett
2011-09-28 4:26 ` Kyle Moffett
2011-09-28 9:20 ` [Drbd-dev] " Philipp Reisner
2011-09-28 9:20 ` Philipp Reisner
2011-09-28 9:21 ` [Drbd-dev] [PATCH 9/9] drbd: Removed outdated comments and code that envisioned VNRs in header 95 Philipp Reisner
2011-09-28 9:21 ` Philipp Reisner
2011-09-23 14:31 ` [Drbd-dev] [PATCH 10/10] drbd: For protocol versions before 100, use mixed header versions Philipp Reisner
2011-09-23 14:31 ` Philipp Reisner
2011-09-23 17:24 ` [Drbd-dev] " Kyle Moffett
2011-09-23 17:24 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109271134.03529.philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.