* [PATCH 2/4] OMAP4: Keyboard: Fix section mismatch in the board file
@ 2011-08-04 18:02 Bjarne Steinsbo
2011-08-12 15:27 ` [PATCHv2 " Bjarne Steinsbo
0 siblings, 1 reply; 5+ messages in thread
From: Bjarne Steinsbo @ 2011-08-04 18:02 UTC (permalink / raw)
To: linux-omap
`keypad_pads' is referred to by `keypad_data' which is
not __initdata, so `keypad_pads' should not be __initdata either.
---
arch/arm/mach-omap2/board-4430sdp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index c7cef44..9e423ac 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -129,7 +129,7 @@ static const int sdp4430_keymap[] = {
KEY(7, 6, KEY_OK),
KEY(7, 7, KEY_DOWN),
};
-static struct omap_device_pad keypad_pads[] __initdata = {
+static struct omap_device_pad keypad_pads[] = {
{ .name = "kpd_col1.kpd_col1",
.enable = OMAP_WAKEUP_EN | OMAP_MUX_MODE1,
},
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file
2011-08-04 18:02 [PATCH 2/4] OMAP4: Keyboard: Fix section mismatch in the board file Bjarne Steinsbo
@ 2011-08-12 15:27 ` Bjarne Steinsbo
2011-08-16 6:53 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Bjarne Steinsbo @ 2011-08-12 15:27 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, Felipe Balbi
`keypad_pads' is referred to by `keypad_data' which is
not __initdata, so `keypad_pads' should not be __initdata either.
Signed-off-by: Bjarne Steinsbo <bsteinsbo@gmail.com>
---
V2: Oops.. Add missing sob.
arch/arm/mach-omap2/board-4430sdp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c
b/arch/arm/mach-omap2/board-4430sdp.c
index c7cef44..9e423ac 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -129,7 +129,7 @@ static const int sdp4430_keymap[] = {
KEY(7, 6, KEY_OK),
KEY(7, 7, KEY_DOWN),
};
-static struct omap_device_pad keypad_pads[] __initdata = {
+static struct omap_device_pad keypad_pads[] = {
{ .name = "kpd_col1.kpd_col1",
.enable = OMAP_WAKEUP_EN | OMAP_MUX_MODE1,
},
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file
2011-08-12 15:27 ` [PATCHv2 " Bjarne Steinsbo
@ 2011-08-16 6:53 ` Felipe Balbi
2011-09-14 7:12 ` Bjarne Steinsbo
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2011-08-16 6:53 UTC (permalink / raw)
To: Bjarne Steinsbo; +Cc: linux-omap, Tony Lindgren, Felipe Balbi
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
On Fri, Aug 12, 2011 at 05:27:52PM +0200, Bjarne Steinsbo wrote:
> `keypad_pads' is referred to by `keypad_data' which is
> not __initdata, so `keypad_pads' should not be __initdata either.
>
> Signed-off-by: Bjarne Steinsbo <bsteinsbo@gmail.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file
2011-08-16 6:53 ` Felipe Balbi
@ 2011-09-14 7:12 ` Bjarne Steinsbo
2011-09-28 18:26 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Bjarne Steinsbo @ 2011-09-14 7:12 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, balbi
I can't see this one queued up anywhere. Did it just slip through the
cracks, or are there any problems with it?
BR,
Bjarne Steinsbo
On Tue, Aug 16, 2011 at 8:53 AM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, Aug 12, 2011 at 05:27:52PM +0200, Bjarne Steinsbo wrote:
>> `keypad_pads' is referred to by `keypad_data' which is
>> not __initdata, so `keypad_pads' should not be __initdata either.
>>
>> Signed-off-by: Bjarne Steinsbo <bsteinsbo@gmail.com>
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
>
> --
> balbi
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 2/4] OMAP4: Keyboard: Fix section mismatch in the board file
2011-09-14 7:12 ` Bjarne Steinsbo
@ 2011-09-28 18:26 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2011-09-28 18:26 UTC (permalink / raw)
To: Bjarne Steinsbo; +Cc: linux-omap, balbi
* Bjarne Steinsbo <bsteinsbo@gmail.com> [110913 23:39]:
> I can't see this one queued up anywhere. Did it just slip through the
> cracks, or are there any problems with it?
Just slipped through the cracks.. Adding into fixes thanks.
Tony
> BR,
>
> Bjarne Steinsbo
>
> On Tue, Aug 16, 2011 at 8:53 AM, Felipe Balbi <balbi@ti.com> wrote:
> > On Fri, Aug 12, 2011 at 05:27:52PM +0200, Bjarne Steinsbo wrote:
> >> `keypad_pads' is referred to by `keypad_data' which is
> >> not __initdata, so `keypad_pads' should not be __initdata either.
> >>
> >> Signed-off-by: Bjarne Steinsbo <bsteinsbo@gmail.com>
> >
> > Reviewed-by: Felipe Balbi <balbi@ti.com>
> >
> > --
> > balbi
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-28 18:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 18:02 [PATCH 2/4] OMAP4: Keyboard: Fix section mismatch in the board file Bjarne Steinsbo
2011-08-12 15:27 ` [PATCHv2 " Bjarne Steinsbo
2011-08-16 6:53 ` Felipe Balbi
2011-09-14 7:12 ` Bjarne Steinsbo
2011-09-28 18:26 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.