From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: "Stéphane Chatty" <chatty@enac.fr>,
"Jiri Kosina" <jkosina@suse.cz>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"USB list" <linux-input@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] autodetection of multitouch devices
Date: Thu, 29 Sep 2011 10:19:56 +0200 [thread overview]
Message-ID: <20110929081956.GA2282@polaris.bitmath.org> (raw)
In-Reply-To: <CAN+gG=HWJ0tXvS8nbmv4u0CyB6tQo36xnhXE0xoRYjpdm2h2NA@mail.gmail.com>
On Wed, Sep 28, 2011 at 11:25:38PM +0200, Benjamin Tissoires wrote:
> On Wed, Sep 28, 2011 at 22:32, Stéphane Chatty <chatty@enac.fr> wrote:
> >
> > Le 26 sept. 2011 à 16:47, Jiri Kosina a écrit :
> >
> >> On Mon, 26 Sep 2011, Henrik Rydberg wrote:
> >>
> >>>>> These two patches finally enable the kernel to handle multitouch devices correctly.
> >>>>> If a device presents in its report descriptors the usage Contact ID, then it is considered as
> >>>>> a multitouch device and handled by hid-multitouch.
> >>>>
> >>>> Hi Banjamin,
> >>>>
> >>>> thanks a lot for working on this. I have now queued the patches in my
> >>>> tree.
> >>>
> >>> Hi Benjamin,
> >>>
> >>> Late as it seems, here are a couple of questions:
> >>>
> >>> 1. How was this tested? By removing all white-listed devices in
> >>> hid-multitouch.c to see if the usual suspects are still picked up?
>
> Well, nearly all the devices that has been included since March passed
> the first patch (I had it in my queue since a long time).
> For now, only Stantum products are known to not work with this patch
> if we remove them from hid_have_special_driver.
I see, thanks.
> As for the blacklist problem, we also know that this is not very
> beautiful, but we are working on a better solution. For the moment, it
> just allows people to have their device working out of the box
> (crossing fingers).
It is great that you share a working solution for most cases, but it
does not look like mainline material yet, does it. A clean solution
should probably modify the driver selection mechanism on a deeper
level, or at least make use of the current whitelist.
Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: "Stéphane Chatty" <chatty@enac.fr>,
"Jiri Kosina" <jkosina@suse.cz>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"USB list" <linux-input@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] autodetection of multitouch devices
Date: Thu, 29 Sep 2011 10:19:56 +0200 [thread overview]
Message-ID: <20110929081956.GA2282@polaris.bitmath.org> (raw)
In-Reply-To: <CAN+gG=HWJ0tXvS8nbmv4u0CyB6tQo36xnhXE0xoRYjpdm2h2NA@mail.gmail.com>
On Wed, Sep 28, 2011 at 11:25:38PM +0200, Benjamin Tissoires wrote:
> On Wed, Sep 28, 2011 at 22:32, Stéphane Chatty <chatty@enac.fr> wrote:
> >
> > Le 26 sept. 2011 à 16:47, Jiri Kosina a écrit :
> >
> >> On Mon, 26 Sep 2011, Henrik Rydberg wrote:
> >>
> >>>>> These two patches finally enable the kernel to handle multitouch devices correctly.
> >>>>> If a device presents in its report descriptors the usage Contact ID, then it is considered as
> >>>>> a multitouch device and handled by hid-multitouch.
> >>>>
> >>>> Hi Banjamin,
> >>>>
> >>>> thanks a lot for working on this. I have now queued the patches in my
> >>>> tree.
> >>>
> >>> Hi Benjamin,
> >>>
> >>> Late as it seems, here are a couple of questions:
> >>>
> >>> 1. How was this tested? By removing all white-listed devices in
> >>> hid-multitouch.c to see if the usual suspects are still picked up?
>
> Well, nearly all the devices that has been included since March passed
> the first patch (I had it in my queue since a long time).
> For now, only Stantum products are known to not work with this patch
> if we remove them from hid_have_special_driver.
I see, thanks.
> As for the blacklist problem, we also know that this is not very
> beautiful, but we are working on a better solution. For the moment, it
> just allows people to have their device working out of the box
> (crossing fingers).
It is great that you share a working solution for most cases, but it
does not look like mainline material yet, does it. A clean solution
should probably modify the driver selection mechanism on a deeper
level, or at least make use of the current whitelist.
Thanks,
Henrik
next prev parent reply other threads:[~2011-09-29 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 14:56 [PATCH 0/2] autodetection of multitouch devices Benjamin Tissoires
2011-09-21 14:56 ` Benjamin Tissoires
2011-09-21 14:56 ` [PATCH 1/2] HID: add " Benjamin Tissoires
2011-09-21 14:56 ` Benjamin Tissoires
2011-09-21 14:56 ` [PATCH 2/2] decide if hid-multitouch needs to handle mt devices Benjamin Tissoires
2011-09-21 14:56 ` Benjamin Tissoires
2011-09-26 12:20 ` [PATCH 0/2] autodetection of multitouch devices Jiri Kosina
2011-09-26 14:46 ` Henrik Rydberg
2011-09-26 14:47 ` Jiri Kosina
2011-09-28 20:32 ` Stéphane Chatty
2011-09-28 20:32 ` Stéphane Chatty
2011-09-28 21:25 ` Benjamin Tissoires
2011-09-29 8:19 ` Henrik Rydberg [this message]
2011-09-29 8:19 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929081956.GA2282@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.