From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
James.Bottomley@HansenPartnership.com, hpa@zytor.com,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFCv3][PATCH 3/4] add seq_print_pow2() function
Date: Fri, 30 Sep 2011 17:08:58 -0700 [thread overview]
Message-ID: <20111001000858.D1CD9117@kernel> (raw)
In-Reply-To: <20111001000856.DD623081@kernel>
In order to get nice, human-readable output, we are going to
use MiB/KiB, etc... in numa_maps. Introduce a helper to do
the conversion from a raw integer over to a string.
I thought about doing this as a new printk() format specifier.
That would be interesting, but it's hard to argue with this
since it's so short and sweet.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/fs/seq_file.c | 11 +++++++++++
linux-2.6.git-dave/include/linux/seq_file.h | 2 ++
2 files changed, 13 insertions(+)
diff -puN fs/seq_file.c~add-seq_print_size fs/seq_file.c
--- linux-2.6.git/fs/seq_file.c~add-seq_print_size 2011-09-30 16:41:04.169957332 -0700
+++ linux-2.6.git-dave/fs/seq_file.c 2011-09-30 16:41:04.181957311 -0700
@@ -386,6 +386,17 @@ int seq_printf(struct seq_file *m, const
}
EXPORT_SYMBOL(seq_printf);
+/*
+ * Prints output with KiB/MiB/etc... suffixes
+ */
+int seq_print_pow2(struct seq_file *seq, u64 size)
+{
+ u64 shifted_size;
+ char unit_str[4];
+ shifted_size = string_get_size_pow2(size, unit_str);
+ return seq_printf(seq, "%llu%s", shifted_size, unit_str);
+}
+
/**
* mangle_path - mangle and copy path to buffer beginning
* @s: buffer start
diff -puN include/linux/seq_file.h~add-seq_print_size include/linux/seq_file.h
--- linux-2.6.git/include/linux/seq_file.h~add-seq_print_size 2011-09-30 16:41:04.173957325 -0700
+++ linux-2.6.git-dave/include/linux/seq_file.h 2011-09-30 16:41:04.181957311 -0700
@@ -3,6 +3,7 @@
#include <linux/types.h>
#include <linux/string.h>
+#include <linux/string_helpers.h>
#include <linux/mutex.h>
#include <linux/cpumask.h>
#include <linux/nodemask.h>
@@ -83,6 +84,7 @@ int seq_escape(struct seq_file *, const
int seq_putc(struct seq_file *m, char c);
int seq_puts(struct seq_file *m, const char *s);
int seq_write(struct seq_file *seq, const void *data, size_t len);
+int seq_print_pow2(struct seq_file *seq, u64 size);
int seq_printf(struct seq_file *, const char *, ...)
__attribute__ ((format (printf,2,3)));
_
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
James.Bottomley@HansenPartnership.com, hpa@zytor.com,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFCv3][PATCH 3/4] add seq_print_pow2() function
Date: Fri, 30 Sep 2011 17:08:58 -0700 [thread overview]
Message-ID: <20111001000858.D1CD9117@kernel> (raw)
In-Reply-To: <20111001000856.DD623081@kernel>
In order to get nice, human-readable output, we are going to
use MiB/KiB, etc... in numa_maps. Introduce a helper to do
the conversion from a raw integer over to a string.
I thought about doing this as a new printk() format specifier.
That would be interesting, but it's hard to argue with this
since it's so short and sweet.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/fs/seq_file.c | 11 +++++++++++
linux-2.6.git-dave/include/linux/seq_file.h | 2 ++
2 files changed, 13 insertions(+)
diff -puN fs/seq_file.c~add-seq_print_size fs/seq_file.c
--- linux-2.6.git/fs/seq_file.c~add-seq_print_size 2011-09-30 16:41:04.169957332 -0700
+++ linux-2.6.git-dave/fs/seq_file.c 2011-09-30 16:41:04.181957311 -0700
@@ -386,6 +386,17 @@ int seq_printf(struct seq_file *m, const
}
EXPORT_SYMBOL(seq_printf);
+/*
+ * Prints output with KiB/MiB/etc... suffixes
+ */
+int seq_print_pow2(struct seq_file *seq, u64 size)
+{
+ u64 shifted_size;
+ char unit_str[4];
+ shifted_size = string_get_size_pow2(size, unit_str);
+ return seq_printf(seq, "%llu%s", shifted_size, unit_str);
+}
+
/**
* mangle_path - mangle and copy path to buffer beginning
* @s: buffer start
diff -puN include/linux/seq_file.h~add-seq_print_size include/linux/seq_file.h
--- linux-2.6.git/include/linux/seq_file.h~add-seq_print_size 2011-09-30 16:41:04.173957325 -0700
+++ linux-2.6.git-dave/include/linux/seq_file.h 2011-09-30 16:41:04.181957311 -0700
@@ -3,6 +3,7 @@
#include <linux/types.h>
#include <linux/string.h>
+#include <linux/string_helpers.h>
#include <linux/mutex.h>
#include <linux/cpumask.h>
#include <linux/nodemask.h>
@@ -83,6 +84,7 @@ int seq_escape(struct seq_file *, const
int seq_putc(struct seq_file *m, char c);
int seq_puts(struct seq_file *m, const char *s);
int seq_write(struct seq_file *seq, const void *data, size_t len);
+int seq_print_pow2(struct seq_file *seq, u64 size);
int seq_printf(struct seq_file *, const char *, ...)
__attribute__ ((format (printf,2,3)));
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-01 0:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 0:08 [RFCv3][PATCH 1/4] replace string_get_size() arrays Dave Hansen
2011-10-01 0:08 ` Dave Hansen
2011-10-01 0:08 ` [RFCv3][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-10-01 0:08 ` Dave Hansen
2011-10-01 0:08 ` Dave Hansen [this message]
2011-10-01 0:08 ` [RFCv3][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-10-01 0:09 ` [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-10-01 0:09 ` Dave Hansen
2011-10-05 6:50 ` David Rientjes
2011-10-05 6:50 ` David Rientjes
2011-10-05 7:09 ` Eric Dumazet
2011-10-05 7:09 ` Eric Dumazet
2011-10-05 7:23 ` David Rientjes
2011-10-05 7:23 ` David Rientjes
2011-10-05 8:54 ` Eric Dumazet
2011-10-05 8:54 ` Eric Dumazet
2011-10-05 19:19 ` David Rientjes
2011-10-05 19:19 ` David Rientjes
2011-10-05 15:22 ` Dave Hansen
2011-10-05 15:22 ` Dave Hansen
2011-10-05 16:28 ` Eric Dumazet
2011-10-05 16:28 ` Eric Dumazet
2011-10-05 19:24 ` David Rientjes
2011-10-05 19:24 ` David Rientjes
2011-10-05 15:21 ` Dave Hansen
2011-10-05 15:21 ` Dave Hansen
2011-10-01 19:29 ` [RFCv3][PATCH 1/4] replace string_get_size() arrays Joe Perches
2011-10-01 19:29 ` Joe Perches
2011-10-01 19:33 ` Joe Perches
2011-10-01 19:33 ` Joe Perches
2011-10-04 19:35 ` Dave Hansen
2011-10-04 19:35 ` Dave Hansen
2011-10-04 20:42 ` Joe Perches
2011-10-04 20:42 ` Joe Perches
2011-10-04 20:51 ` Dave Hansen
2011-10-04 20:51 ` Dave Hansen
2011-10-04 21:18 ` Joe Perches
2011-10-04 21:18 ` Joe Perches
2011-10-05 6:58 ` David Rientjes
2011-10-05 6:58 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001000858.D1CD9117@kernel \
--to=dave@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.