From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Padmavathi Venna <padma.v@samsung.com>
Cc: kgene.kim@samsung.com, padma.kvr@gmail.com,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khilman@ti.com,
nsekhar@ti.com, hsweeten@visionengravers.com, rmallon@gmail.com,
s.hauer@pengutronix.de, u.kleine-koenig@pengutronix.de,
plagnioj@jcrosoft.com, amit.kucheria@canonical.com,
kernel@pengutronix.de, hjk@hansjkoch.de
Subject: Re: [PATCH 1/2] ARM: CLKDEV: Add Common Macro for clk_lookup
Date: Sat, 1 Oct 2011 16:29:38 +0100 [thread overview]
Message-ID: <20111001152938.GD11710@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1317381097-2691-2-git-send-email-padma.v@samsung.com>
On Fri, Sep 30, 2011 at 04:41:36PM +0530, Padmavathi Venna wrote:
> +#define CLKDEV_INIT(d, n, c) \
> + { \
> + .dev_id = d, \
> + .con_id = n, \
> + .clk = &c, \
> + },
> +
As Heartley says, the trailing , and the end should not be there - it
should be with each use of CLKDEV_INIT(). The reasoning is that it
makes the use of macros much more conventional and consistent throughout
the kernel:
struct cl_lookup foo_lookups[] = {
CLKDEV_INIT(...),
CLKDEV_INIT(...),
};
struct cl_lookup bar_lookup = CLKDEV_INIT(...);
Could you re-spin with that change please?
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: CLKDEV: Add Common Macro for clk_lookup
Date: Sat, 1 Oct 2011 16:29:38 +0100 [thread overview]
Message-ID: <20111001152938.GD11710@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1317381097-2691-2-git-send-email-padma.v@samsung.com>
On Fri, Sep 30, 2011 at 04:41:36PM +0530, Padmavathi Venna wrote:
> +#define CLKDEV_INIT(d, n, c) \
> + { \
> + .dev_id = d, \
> + .con_id = n, \
> + .clk = &c, \
> + },
> +
As Heartley says, the trailing , and the end should not be there - it
should be with each use of CLKDEV_INIT(). The reasoning is that it
makes the use of macros much more conventional and consistent throughout
the kernel:
struct cl_lookup foo_lookups[] = {
CLKDEV_INIT(...),
CLKDEV_INIT(...),
};
struct cl_lookup bar_lookup = CLKDEV_INIT(...);
Could you re-spin with that change please?
Thanks.
next prev parent reply other threads:[~2011-10-01 15:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 11:11 [PATCH 0/2]: Add a common macro for creating struct clk_lookup entries Padmavathi Venna
2011-09-30 11:11 ` Padmavathi Venna
2011-09-30 11:11 ` [PATCH 1/2] ARM: CLKDEV: Add Common Macro for clk_lookup Padmavathi Venna
2011-09-30 11:11 ` Padmavathi Venna
2011-09-30 17:03 ` H Hartley Sweeten
2011-09-30 17:03 ` H Hartley Sweeten
2011-09-30 17:17 ` H Hartley Sweeten
2011-09-30 17:17 ` H Hartley Sweeten
2011-10-01 15:29 ` Russell King - ARM Linux [this message]
2011-10-01 15:29 ` Russell King - ARM Linux
2011-10-04 5:20 ` padma venkat
2011-10-04 5:20 ` padma venkat
2011-09-30 11:11 ` [PATCH 2/2] ARM: Switch to using CLKDEV_INIT macro for creating clk_lookup instance Padmavathi Venna
2011-09-30 11:11 ` Padmavathi Venna
2011-09-30 11:26 ` Hans J. Koch
2011-09-30 11:26 ` Hans J. Koch
2011-10-01 15:31 ` Russell King - ARM Linux
2011-10-01 15:31 ` Russell King - ARM Linux
2011-09-30 12:35 ` Ryan Mallon
2011-09-30 12:35 ` Ryan Mallon
2011-09-30 17:08 ` H Hartley Sweeten
2011-09-30 17:08 ` H Hartley Sweeten
2011-09-30 12:41 ` Amit Kucheria
2011-09-30 12:41 ` Amit Kucheria
2011-09-30 17:03 ` H Hartley Sweeten
2011-09-30 17:03 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001152938.GD11710@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=amit.kucheria@canonical.com \
--cc=hjk@hansjkoch.de \
--cc=hsweeten@visionengravers.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=plagnioj@jcrosoft.com \
--cc=rmallon@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.