From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC
Date: Sun, 2 Oct 2011 19:56:30 +0100 [thread overview]
Message-ID: <20111002185630.GI2857@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317559264.21926.1.camel@phoenix>
On Sun, Oct 02, 2011 at 08:41:04PM +0800, Axel Lin wrote:
> Current code set update bits for WM8753_LDAC and WM8753_RDAC twice,
> but missed setting update bits for WM8753_LADC and WM8753_RADC.
>
> I think it is a copy-paste bug in commit 776065
> "ASoC: codecs: wm8753: Fix register cache incoherency".
Looks like it, yes. Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC
Date: Sun, 2 Oct 2011 19:56:30 +0100 [thread overview]
Message-ID: <20111002185630.GI2857@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317559264.21926.1.camel@phoenix>
On Sun, Oct 02, 2011 at 08:41:04PM +0800, Axel Lin wrote:
> Current code set update bits for WM8753_LDAC and WM8753_RDAC twice,
> but missed setting update bits for WM8753_LADC and WM8753_RADC.
>
> I think it is a copy-paste bug in commit 776065
> "ASoC: codecs: wm8753: Fix register cache incoherency".
Looks like it, yes. Applied, thanks.
next prev parent reply other threads:[~2011-10-02 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 12:41 [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC Axel Lin
2011-10-02 12:41 ` Axel Lin
2011-10-02 18:56 ` Mark Brown [this message]
2011-10-02 18:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002185630.GI2857@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.