From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
Date: Tue, 4 Oct 2011 10:51:24 +0100 [thread overview]
Message-ID: <20111004095124.GA3250@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317720272.2536.2.camel@phoenix>
On Tue, Oct 04, 2011 at 05:24:32PM +0800, Axel Lin wrote:
> I just found that after commit be3ea3b9e
> "SoC: Use new register map API for ASoC generic physical I/O",
> snd_soc_codec_set_cache_io does not set codec->hw_write any more.
> It is still used in some drivers. e.g.
> In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
> For the drivers that is using snd_soc_codec_set_cache_io now,
> where is the place to set codec->hw_write callback now?
These drivers should be using the standard I/O functions, probably
they're looking for the cache_bypass flag. Either that or convert to
use regmap directly.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
Date: Tue, 4 Oct 2011 10:51:24 +0100 [thread overview]
Message-ID: <20111004095124.GA3250@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317720272.2536.2.camel@phoenix>
On Tue, Oct 04, 2011 at 05:24:32PM +0800, Axel Lin wrote:
> I just found that after commit be3ea3b9e
> "SoC: Use new register map API for ASoC generic physical I/O",
> snd_soc_codec_set_cache_io does not set codec->hw_write any more.
> It is still used in some drivers. e.g.
> In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
> For the drivers that is using snd_soc_codec_set_cache_io now,
> where is the place to set codec->hw_write callback now?
These drivers should be using the standard I/O functions, probably
they're looking for the cache_bypass flag. Either that or convert to
use regmap directly.
next prev parent reply other threads:[~2011-10-04 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 9:24 ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now Axel Lin
2011-10-04 9:24 ` Axel Lin
2011-10-04 9:51 ` Mark Brown [this message]
2011-10-04 9:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004095124.GA3250@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.