From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: alsa-devel@alsa-project.org, hidave.darkstar@gmail.com,
linux-kernel@vger.kernel.org, lrg@ti.com,
peter.hsiang@maxim-ic.com, axel.lin@gmail.com,
jesse.marroquin@maxim-ic.com
Subject: Re: [PATCH 1/2] ASoC: max98088 codec: Catch driver bugs for eq channel name
Date: Tue, 4 Oct 2011 12:05:45 +0100 [thread overview]
Message-ID: <20111004110545.GI3250@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317682541-28494-1-git-send-email-rmallon@gmail.com>
On Tue, Oct 04, 2011 at 09:55:40AM +1100, Ryan Mallon wrote:
> Move the EQ channel names to a separate array and iterate over it in
> max98088_get_channel rather than duplicating the hardcoded channel
> names. Add an error message if an invalid channel is passed and check
> the error in the callers.
Applied both, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: axel.lin@gmail.com, linux-kernel@vger.kernel.org, lrg@ti.com,
alsa-devel@alsa-project.org, peter.hsiang@maxim-ic.com,
jesse.marroquin@maxim-ic.com, hidave.darkstar@gmail.com
Subject: Re: [PATCH 1/2] ASoC: max98088 codec: Catch driver bugs for eq channel name
Date: Tue, 4 Oct 2011 12:05:45 +0100 [thread overview]
Message-ID: <20111004110545.GI3250@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317682541-28494-1-git-send-email-rmallon@gmail.com>
On Tue, Oct 04, 2011 at 09:55:40AM +1100, Ryan Mallon wrote:
> Move the EQ channel names to a separate array and iterate over it in
> max98088_get_channel rather than duplicating the hardcoded channel
> names. Add an error message if an invalid channel is passed and check
> the error in the callers.
Applied both, thanks.
next prev parent reply other threads:[~2011-10-04 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 22:55 [PATCH 1/2] ASoC: max98088 codec: Catch driver bugs for eq channel name Ryan Mallon
2011-10-03 22:55 ` [PATCH 2/2] ASoC: max98095 codec: Catch driver bugs for biquad " Ryan Mallon
2011-10-04 11:05 ` Mark Brown [this message]
2011-10-04 11:05 ` [PATCH 1/2] ASoC: max98088 codec: Catch driver bugs for eq " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004110545.GI3250@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=jesse.marroquin@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.hsiang@maxim-ic.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.