* [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
@ 2011-10-04 12:27 Olaf Hering
2011-10-04 13:00 ` Olaf Hering
2011-10-06 12:11 ` Tim Deegan
0 siblings, 2 replies; 3+ messages in thread
From: Olaf Hering @ 2011-10-04 12:27 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1317731210 -7200
# Node ID e77dd1bf489436d9f115be5d77327d1bbde1f1d2
# Parent 28556fcb81957a996b2c4b23a450cfefd95338b3
p2m: use correct p2m_type_t in clear_mmio_p2m_entry
clear_mmio_p2m_entry() should mark the gfn as invalid.
Use proper name instead of numerical value. The currently used value of
zero means p2m_ram_rw.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 28556fcb8195 -r e77dd1bf4894 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -628,7 +628,7 @@ clear_mmio_p2m_entry(struct domain *d, u
return 0;
}
p2m_lock(p2m);
- rc = set_p2m_entry(p2m, gfn, _mfn(INVALID_MFN), 0, 0, p2m->default_access);
+ rc = set_p2m_entry(p2m, gfn, _mfn(INVALID_MFN), 0, p2m_invalid, p2m->default_access);
audit_p2m(p2m, 1);
p2m_unlock(p2m);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
2011-10-04 12:27 [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry Olaf Hering
@ 2011-10-04 13:00 ` Olaf Hering
2011-10-06 12:11 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2011-10-04 13:00 UTC (permalink / raw)
To: xen-devel
On Tue, Oct 04, Olaf Hering wrote:
> p2m: use correct p2m_type_t in clear_mmio_p2m_entry
>
> clear_mmio_p2m_entry() should mark the gfn as invalid.
> Use proper name instead of numerical value. The currently used value of
> zero means p2m_ram_rw.
This bug is also in xen-4.1-testing.hg
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry
2011-10-04 12:27 [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry Olaf Hering
2011-10-04 13:00 ` Olaf Hering
@ 2011-10-06 12:11 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Tim Deegan @ 2011-10-06 12:11 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
At 14:27 +0200 on 04 Oct (1317738439), Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1317731210 -7200
> # Node ID e77dd1bf489436d9f115be5d77327d1bbde1f1d2
> # Parent 28556fcb81957a996b2c4b23a450cfefd95338b3
> p2m: use correct p2m_type_t in clear_mmio_p2m_entry
>
> clear_mmio_p2m_entry() should mark the gfn as invalid.
> Use proper name instead of numerical value. The currently used value of
> zero means p2m_ram_rw.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Applied, thanks, and backported to 4.1-testing
Tim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-06 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-04 12:27 [PATCH] p2m: use correct p2m_type_t in clear_mmio_p2m_entry Olaf Hering
2011-10-04 13:00 ` Olaf Hering
2011-10-06 12:11 ` Tim Deegan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.