All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Greg KH <greg@kroah.com>
Cc: Himanshu Chauhan <hschauhan@nulltrace.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernelnewbies@kernelnewbies.org"
	<kernelnewbies@kernelnewbies.org>
Subject: Re: [lm-sensors] [PATCH] hwmon class driver registration with a
Date: Thu, 06 Oct 2011 19:07:52 +0000	[thread overview]
Message-ID: <20111006190752.GA28455@ericsson.com> (raw)
In-Reply-To: <20111006182500.GA18607@kroah.com>

On Thu, Oct 06, 2011 at 02:25:00PM -0400, Greg KH wrote:
> On Thu, Oct 06, 2011 at 09:40:11AM +0530, Himanshu Chauhan wrote:
> > Hi Greg,
> > 
> > > 
> > > How do you later remove a device created with this new interface?  As it
> > > is, I think the existing calls will fail, right?
> > > 
> > If I have not missed out anything from hwmon_device_unregister(), it shouldn't
> > fail. Why did you point that out?
> 
> If you create a device with a call to device_create() with a dev_t set,
> it is usually cleaned up with a call to device_destroy(), but you are
> right, a simple call to device_unregister() will still work properly.
> 
> So nevermind, sorry for the noise.
> 
Not entirely noise. Since the new registration call is not exported in the patch,
any code using it won't be compilable as module, which in turn means
that hwmon_device_unregister() was never called.
So while we know that it _should_ work, we also know that it was not tested.

> What you do need to determine is if this is a device node you really
> want to be creating in this manner, as it is a new user/kernel API,
> right?
> 
And why, and what for.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Greg KH <greg@kroah.com>
Cc: Himanshu Chauhan <hschauhan@nulltrace.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernelnewbies@kernelnewbies.org"
	<kernelnewbies@kernelnewbies.org>
Subject: Re: [lm-sensors] [PATCH] hwmon class driver registration with a device number
Date: Thu, 6 Oct 2011 12:07:52 -0700	[thread overview]
Message-ID: <20111006190752.GA28455@ericsson.com> (raw)
In-Reply-To: <20111006182500.GA18607@kroah.com>

On Thu, Oct 06, 2011 at 02:25:00PM -0400, Greg KH wrote:
> On Thu, Oct 06, 2011 at 09:40:11AM +0530, Himanshu Chauhan wrote:
> > Hi Greg,
> > 
> > > 
> > > How do you later remove a device created with this new interface?  As it
> > > is, I think the existing calls will fail, right?
> > > 
> > If I have not missed out anything from hwmon_device_unregister(), it shouldn't
> > fail. Why did you point that out?
> 
> If you create a device with a call to device_create() with a dev_t set,
> it is usually cleaned up with a call to device_destroy(), but you are
> right, a simple call to device_unregister() will still work properly.
> 
> So nevermind, sorry for the noise.
> 
Not entirely noise. Since the new registration call is not exported in the patch,
any code using it won't be compilable as module, which in turn means
that hwmon_device_unregister() was never called.
So while we know that it _should_ work, we also know that it was not tested.

> What you do need to determine is if this is a device node you really
> want to be creating in this manner, as it is a new user/kernel API,
> right?
> 
And why, and what for.

Guenter

  reply	other threads:[~2011-10-06 19:07 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 17:13 [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-05 17:13 ` Himanshu Chauhan
2011-10-05 18:30 ` [lm-sensors] [PATCH] hwmon class driver registration with a Guenter Roeck
2011-10-05 18:30   ` [PATCH] hwmon class driver registration with a device number Guenter Roeck
2011-10-06  4:06   ` Himanshu Chauhan
2011-10-06  4:18     ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-06  4:06     ` [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-06  5:19     ` [lm-sensors] [PATCH] hwmon class driver registration with a Guenter Roeck
2011-10-06  5:19       ` [PATCH] hwmon class driver registration with a device number Guenter Roeck
2011-10-06  7:43       ` [lm-sensors] [PATCH] hwmon class driver registration with a Jean Delvare
2011-10-06  7:43         ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Jean Delvare
2011-10-06 15:12         ` Himanshu Chauhan
2011-10-06 15:24           ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-06 15:46           ` Alan Cox
2011-10-06 15:46             ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Alan Cox
2011-10-06 16:25             ` Himanshu Chauhan
2011-10-06 16:37               ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-06 15:15         ` Guenter Roeck
2011-10-06 15:15           ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Guenter Roeck
2011-10-06 16:43           ` Himanshu Chauhan
2011-10-06 16:55             ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-05 19:33 ` [PATCH] hwmon class driver registration with a device number Greg KH
2011-10-05 19:33   ` Greg KH
2011-10-06  4:10   ` Himanshu Chauhan
2011-10-06  4:22     ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-06  4:10     ` [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-06 18:25     ` Greg KH
2011-10-06 18:25       ` Greg KH
2011-10-06 18:25       ` [lm-sensors] [PATCH] hwmon class driver registration with a Greg KH
2011-10-06 19:07       ` Guenter Roeck [this message]
2011-10-06 19:07         ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Guenter Roeck
2011-10-07  6:42         ` Himanshu Chauhan
2011-10-07  6:54           ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-07  6:42           ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-07  6:52           ` Greg KH
2011-10-07  6:52             ` Greg KH
2011-10-07  6:52             ` [lm-sensors] [PATCH] hwmon class driver registration with a Greg KH
2011-10-07  9:56             ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-07 10:08               ` [lm-sensors] [PATCH] hwmon class driver registration with a Himanshu Chauhan
2011-10-07  9:56               ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-07 11:11               ` [lm-sensors] [PATCH] hwmon class driver registration with a Jonathan Cameron
2011-10-07 11:11                 ` [lm-sensors] [PATCH] hwmon class driver registration with a device number Jonathan Cameron
2011-10-07 15:46               ` Greg KH
2011-10-07 15:46                 ` Greg KH
2011-10-07 15:46                 ` [lm-sensors] [PATCH] hwmon class driver registration with a Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111006190752.GA28455@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=greg@kroah.com \
    --cc=hschauhan@nulltrace.org \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.