From: Tony Lindgren <tony@atomide.com>
To: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Joe Perches <joe@perches.com>,
linux-omap@vger.kernel.org, Timo Teras <timo.teras@solidboot.com>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH v2] omap: dmtimer: convert printk to pr_err / WARN
Date: Thu, 6 Oct 2011 13:18:27 -0700 [thread overview]
Message-ID: <20111006201827.GT6324@atomide.com> (raw)
In-Reply-To: <1317922204-12512-1-git-send-email-vjaquez@igalia.com>
* Víctor Manuel Jáquez Leal <vjaquez@igalia.com> [111006 09:56]:
> Convert a printk(KERN_ERR) message in the driver to pr_err(), and
> use WARN() instead of a custom log message with a stack dump.
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Looks like this won't apply with the changes we have queued up,
care to refresh this against linux-omap master branch (or dmtimer
branch)?
Regards,
Tony
> ---
> arch/arm/plat-omap/dmtimer.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index ee9f6eb..dead0f3 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -322,7 +322,7 @@ static void omap_dm_timer_wait_for_reset(struct omap_dm_timer *timer)
> while (!(omap_dm_timer_read_reg(timer, OMAP_TIMER_SYS_STAT_REG) & 1)) {
> c++;
> if (c > 100000) {
> - printk(KERN_ERR "Timer failed to reset\n");
> + pr_err("Timer failed to reset\n");
> return;
> }
> }
> @@ -397,9 +397,7 @@ struct omap_dm_timer *omap_dm_timer_request_specific(int id)
> spin_lock_irqsave(&dm_timer_lock, flags);
> if (id <= 0 || id > dm_timer_count || dm_timers[id-1].reserved) {
> spin_unlock_irqrestore(&dm_timer_lock, flags);
> - printk("BUG: warning at %s:%d/%s(): unable to get timer %d\n",
> - __FILE__, __LINE__, __func__, id);
> - dump_stack();
> + WARN(1, "unable to get timer %d\n", id);
> return NULL;
> }
>
> --
> 1.7.6.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] omap: dmtimer: convert printk to pr_err / WARN
Date: Thu, 6 Oct 2011 13:18:27 -0700 [thread overview]
Message-ID: <20111006201827.GT6324@atomide.com> (raw)
In-Reply-To: <1317922204-12512-1-git-send-email-vjaquez@igalia.com>
* V?ctor Manuel J?quez Leal <vjaquez@igalia.com> [111006 09:56]:
> Convert a printk(KERN_ERR) message in the driver to pr_err(), and
> use WARN() instead of a custom log message with a stack dump.
>
> Signed-off-by: V?ctor Manuel J?quez Leal <vjaquez@igalia.com>
Looks like this won't apply with the changes we have queued up,
care to refresh this against linux-omap master branch (or dmtimer
branch)?
Regards,
Tony
> ---
> arch/arm/plat-omap/dmtimer.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index ee9f6eb..dead0f3 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -322,7 +322,7 @@ static void omap_dm_timer_wait_for_reset(struct omap_dm_timer *timer)
> while (!(omap_dm_timer_read_reg(timer, OMAP_TIMER_SYS_STAT_REG) & 1)) {
> c++;
> if (c > 100000) {
> - printk(KERN_ERR "Timer failed to reset\n");
> + pr_err("Timer failed to reset\n");
> return;
> }
> }
> @@ -397,9 +397,7 @@ struct omap_dm_timer *omap_dm_timer_request_specific(int id)
> spin_lock_irqsave(&dm_timer_lock, flags);
> if (id <= 0 || id > dm_timer_count || dm_timers[id-1].reserved) {
> spin_unlock_irqrestore(&dm_timer_lock, flags);
> - printk("BUG: warning at %s:%d/%s(): unable to get timer %d\n",
> - __FILE__, __LINE__, __func__, id);
> - dump_stack();
> + WARN(1, "unable to get timer %d\n", id);
> return NULL;
> }
>
> --
> 1.7.6.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>
Cc: Joe Perches <joe@perches.com>,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Timo Teras <timo.teras@solidboot.com>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH v2] omap: dmtimer: convert printk to pr_err / WARN
Date: Thu, 6 Oct 2011 13:18:27 -0700 [thread overview]
Message-ID: <20111006201827.GT6324@atomide.com> (raw)
In-Reply-To: <1317922204-12512-1-git-send-email-vjaquez@igalia.com>
* Víctor Manuel Jáquez Leal <vjaquez@igalia.com> [111006 09:56]:
> Convert a printk(KERN_ERR) message in the driver to pr_err(), and
> use WARN() instead of a custom log message with a stack dump.
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Looks like this won't apply with the changes we have queued up,
care to refresh this against linux-omap master branch (or dmtimer
branch)?
Regards,
Tony
> ---
> arch/arm/plat-omap/dmtimer.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index ee9f6eb..dead0f3 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -322,7 +322,7 @@ static void omap_dm_timer_wait_for_reset(struct omap_dm_timer *timer)
> while (!(omap_dm_timer_read_reg(timer, OMAP_TIMER_SYS_STAT_REG) & 1)) {
> c++;
> if (c > 100000) {
> - printk(KERN_ERR "Timer failed to reset\n");
> + pr_err("Timer failed to reset\n");
> return;
> }
> }
> @@ -397,9 +397,7 @@ struct omap_dm_timer *omap_dm_timer_request_specific(int id)
> spin_lock_irqsave(&dm_timer_lock, flags);
> if (id <= 0 || id > dm_timer_count || dm_timers[id-1].reserved) {
> spin_unlock_irqrestore(&dm_timer_lock, flags);
> - printk("BUG: warning at %s:%d/%s(): unable to get timer %d\n",
> - __FILE__, __LINE__, __func__, id);
> - dump_stack();
> + WARN(1, "unable to get timer %d\n", id);
> return NULL;
> }
>
> --
> 1.7.6.3
>
next prev parent reply other threads:[~2011-10-06 20:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 10:48 [PATCH] omap: dmtimer: convert printk to pr_* Víctor Manuel Jáquez Leal
2011-10-06 10:48 ` Víctor Manuel Jáquez Leal
2011-10-06 10:48 ` Víctor Manuel Jáquez Leal
2011-10-06 15:19 ` Joe Perches
2011-10-06 15:19 ` Joe Perches
2011-10-06 15:19 ` Joe Perches
2011-10-06 16:26 ` Víctor M. Jáquez L.
2011-10-06 16:26 ` Víctor M. Jáquez L.
2011-10-06 16:26 ` Víctor M. Jáquez L.
2011-10-06 17:30 ` [PATCH v2] omap: dmtimer: convert printk to pr_err / WARN Víctor Manuel Jáquez Leal
2011-10-06 17:30 ` Víctor Manuel Jáquez Leal
2011-10-06 17:30 ` Víctor Manuel Jáquez Leal
2011-10-06 20:18 ` Tony Lindgren [this message]
2011-10-06 20:18 ` Tony Lindgren
2011-10-06 20:18 ` Tony Lindgren
2011-10-07 8:50 ` [PATCH v3] omap: dmtimer: convert printk to pr_err Víctor Manuel Jáquez Leal
2011-10-07 8:50 ` Víctor Manuel Jáquez Leal
2011-10-07 9:22 ` Russell King - ARM Linux
2011-10-07 9:22 ` Russell King - ARM Linux
2011-10-07 9:22 ` Russell King - ARM Linux
2011-10-07 10:46 ` Víctor M. Jáquez L.
2011-10-07 10:46 ` Víctor M. Jáquez L.
2011-10-07 10:46 ` Víctor M. Jáquez L.
2011-10-07 17:40 ` Joe Perches
2011-10-07 17:40 ` Joe Perches
2011-10-07 19:18 ` Russell King - ARM Linux
2011-10-07 19:18 ` Russell King - ARM Linux
2011-10-07 19:48 ` Joe Perches
2011-10-07 19:48 ` Joe Perches
2011-10-07 19:57 ` Russell King - ARM Linux
2011-10-07 19:57 ` Russell King - ARM Linux
2011-10-07 20:02 ` Joe Perches
2011-10-07 20:02 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006201827.GT6324@atomide.com \
--to=tony@atomide.com \
--cc=harvey.harrison@gmail.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=timo.teras@solidboot.com \
--cc=vjaquez@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.