From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Abhilash K V <abhilash.kv@ti.com>,
Chase Maupin <chase.maupin@ti.com>
Subject: Re: [PATCH v2] ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list
Date: Thu, 6 Oct 2011 16:29:00 -0700 [thread overview]
Message-ID: <20111006232900.GC6324@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110061723550.4611@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [111006 15:50]:
>
> Commit d6504acd2125984c61dce24727dd3842d0144015 ("OMAP2+: hwmod:
> remove OMAP_CHIP*") tests the inverse condition of what it should be
> testing for the return value from omap_hwmod_register(). This causes
> several IP blocks to not be registered on several OMAP3 family devices.
>
> Fixing that bug also unmasked another bug, originally reported by
> Chase Maupin <chase.maupin@ti.com> and then subsequently by Abhilash K
> V <abhilash.kv@ti.com>, which caused SmartReflex IP blocks to be
> registered on SoCs that don't support them.
>
> Thanks to Russell King - ARM Linux <linux@arm.linux.org.uk> for comments
> on a previous version of the patch.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Chase Maupin <chase.maupin@ti.com>
> Cc: Abhilash K V <abhilash.kv@ti.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> ---
>
> This version incorporates some comments from RMK.
Thanks, updating in fixes-part2.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list
Date: Thu, 6 Oct 2011 16:29:00 -0700 [thread overview]
Message-ID: <20111006232900.GC6324@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110061723550.4611@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [111006 15:50]:
>
> Commit d6504acd2125984c61dce24727dd3842d0144015 ("OMAP2+: hwmod:
> remove OMAP_CHIP*") tests the inverse condition of what it should be
> testing for the return value from omap_hwmod_register(). This causes
> several IP blocks to not be registered on several OMAP3 family devices.
>
> Fixing that bug also unmasked another bug, originally reported by
> Chase Maupin <chase.maupin@ti.com> and then subsequently by Abhilash K
> V <abhilash.kv@ti.com>, which caused SmartReflex IP blocks to be
> registered on SoCs that don't support them.
>
> Thanks to Russell King - ARM Linux <linux@arm.linux.org.uk> for comments
> on a previous version of the patch.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Chase Maupin <chase.maupin@ti.com>
> Cc: Abhilash K V <abhilash.kv@ti.com>
> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> ---
>
> This version incorporates some comments from RMK.
Thanks, updating in fixes-part2.
Tony
next prev parent reply other threads:[~2011-10-06 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 20:39 [PATCH] ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list Paul Walmsley
2011-10-06 20:39 ` Paul Walmsley
2011-10-06 20:43 ` Tony Lindgren
2011-10-06 20:43 ` Tony Lindgren
2011-10-06 22:35 ` Russell King - ARM Linux
2011-10-06 22:35 ` Russell King - ARM Linux
2011-10-06 23:19 ` Paul Walmsley
2011-10-06 23:19 ` Paul Walmsley
2011-10-06 23:24 ` [PATCH v2] " Paul Walmsley
2011-10-06 23:24 ` Paul Walmsley
2011-10-06 23:29 ` Tony Lindgren [this message]
2011-10-06 23:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006232900.GC6324@atomide.com \
--to=tony@atomide.com \
--cc=abhilash.kv@ti.com \
--cc=chase.maupin@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.