From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
nfont@linux.vnet.ibm.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] mm: memory hotplug: Check if pages are correctly reserved on a per-section basis
Date: Mon, 10 Oct 2011 15:00:38 -0700 [thread overview]
Message-ID: <20111010150038.ac161977.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111010071119.GE6418@suse.de>
On Mon, 10 Oct 2011 08:11:19 +0100
Mel Gorman <mgorman@suse.de> wrote:
> It is expected that memory being brought online is PageReserved
> similar to what happens when the page allocator is being brought up.
> Memory is onlined in "memory blocks" which consist of one or more
> sections. Unfortunately, the code that verifies PageReserved is
> currently assuming that the memmap backing all these pages is virtually
> contiguous which is only the case when CONFIG_SPARSEMEM_VMEMMAP is set.
> As a result, memory hot-add is failing on !VMEMMAP configurations
> with the message;
>
> kernel: section number XXX page number 256 not reserved, was it already online?
>
> This patch updates the PageReserved check to lookup struct page once
> per section to guarantee the correct struct page is being checked.
>
Nathan's earlier version of this patch is already in linux-next, via
Greg. We should drop the old version and get the new one merged
instead.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@suse.de>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
nfont@linux.vnet.ibm.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] mm: memory hotplug: Check if pages are correctly reserved on a per-section basis
Date: Mon, 10 Oct 2011 15:00:38 -0700 [thread overview]
Message-ID: <20111010150038.ac161977.akpm@linux-foundation.org> (raw)
In-Reply-To: <20111010071119.GE6418@suse.de>
On Mon, 10 Oct 2011 08:11:19 +0100
Mel Gorman <mgorman@suse.de> wrote:
> It is expected that memory being brought online is PageReserved
> similar to what happens when the page allocator is being brought up.
> Memory is onlined in "memory blocks" which consist of one or more
> sections. Unfortunately, the code that verifies PageReserved is
> currently assuming that the memmap backing all these pages is virtually
> contiguous which is only the case when CONFIG_SPARSEMEM_VMEMMAP is set.
> As a result, memory hot-add is failing on !VMEMMAP configurations
> with the message;
>
> kernel: section number XXX page number 256 not reserved, was it already online?
>
> This patch updates the PageReserved check to lookup struct page once
> per section to guarantee the correct struct page is being checked.
>
Nathan's earlier version of this patch is already in linux-next, via
Greg. We should drop the old version and get the new one merged
instead.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-10 22:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 7:11 [PATCH] mm: memory hotplug: Check if pages are correctly reserved on a per-section basis Mel Gorman
2011-10-10 7:11 ` Mel Gorman
2011-10-10 22:00 ` Andrew Morton [this message]
2011-10-10 22:00 ` Andrew Morton
2011-10-10 23:24 ` Greg KH
2011-10-10 23:24 ` Greg KH
2011-10-10 23:28 ` Andrew Morton
2011-10-10 23:28 ` Andrew Morton
2011-10-10 23:35 ` Greg KH
2011-10-10 23:35 ` Greg KH
2011-10-10 23:41 ` Andrew Morton
2011-10-10 23:41 ` Andrew Morton
2011-10-11 4:26 ` David Rientjes
2011-10-11 4:26 ` David Rientjes
2011-10-11 7:27 ` Mel Gorman
2011-10-11 7:27 ` Mel Gorman
2011-10-11 14:44 ` Nathan Fontenot
2011-10-11 14:44 ` Nathan Fontenot
2011-10-12 1:16 ` IBM
2011-10-12 1:16 ` IBM
2011-10-17 14:38 ` Mel Gorman
2011-10-17 14:38 ` Mel Gorman
2011-10-18 0:45 ` KAMEZAWA Hiroyuki
2011-10-18 0:45 ` KAMEZAWA Hiroyuki
2011-10-20 5:19 ` David Rientjes
2011-10-20 5:19 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010150038.ac161977.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.