All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: akpm@google.com, linux-omap@vger.kernel.org,
	linux@arm.linux.org.uk, tony@atomide.com,
	linus.walleij@linaro.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
	manuel.lauss@gmail.com, cjb@laptop.org, dwmw2@infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] leds-class: change back LEDS_CLASS to tristate instead of bool
Date: Mon, 10 Oct 2011 22:54:09 +0400	[thread overview]
Message-ID: <20111010185409.GA8787@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1317113432-7299-1-git-send-email-bryan.wu@canonical.com>

On Tue, Sep 27, 2011 at 04:50:32PM +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it as
> module.  So change this option back as tristate and treak the help message
> as well.
> 
> LEDS_TRIGGERS depends on LEDS_CLASSS, which should be tristate.  So set it
> as tristate too and update header files as well.
> 
> Change those ifdefs to take care of module configuration.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Won't this break linking if POWER_SUPPLY=y and LEDS_TRIGGERS=m?

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

WARNING: multiple messages have this Message-ID (diff)
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds-class: change back LEDS_CLASS to tristate instead of bool
Date: Mon, 10 Oct 2011 22:54:09 +0400	[thread overview]
Message-ID: <20111010185409.GA8787@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1317113432-7299-1-git-send-email-bryan.wu@canonical.com>

On Tue, Sep 27, 2011 at 04:50:32PM +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it as
> module.  So change this option back as tristate and treak the help message
> as well.
> 
> LEDS_TRIGGERS depends on LEDS_CLASSS, which should be tristate.  So set it
> as tristate too and update header files as well.
> 
> Change those ifdefs to take care of module configuration.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Won't this break linking if POWER_SUPPLY=y and LEDS_TRIGGERS=m?

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk, rpurdie@rpsys.net,
	manuel.lauss@gmail.com, cjb@laptop.org, dwmw2@infradead.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linus.walleij@linaro.org, akpm@google.com
Subject: Re: [PATCH] leds-class: change back LEDS_CLASS to tristate instead of bool
Date: Mon, 10 Oct 2011 22:54:09 +0400	[thread overview]
Message-ID: <20111010185409.GA8787@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1317113432-7299-1-git-send-email-bryan.wu@canonical.com>

On Tue, Sep 27, 2011 at 04:50:32PM +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it as
> module.  So change this option back as tristate and treak the help message
> as well.
> 
> LEDS_TRIGGERS depends on LEDS_CLASSS, which should be tristate.  So set it
> as tristate too and update header files as well.
> 
> Change those ifdefs to take care of module configuration.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Won't this break linking if POWER_SUPPLY=y and LEDS_TRIGGERS=m?

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

  parent reply	other threads:[~2011-10-10 18:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27  8:50 [PATCH] leds-class: change back LEDS_CLASS to tristate instead of bool Bryan Wu
2011-09-27  8:50 ` Bryan Wu
2011-09-27  8:50 ` Bryan Wu
2011-09-29  2:00 ` Bryan Wu
2011-09-29  2:00 ` Bryan Wu
2011-09-29  2:00   ` Bryan Wu
2011-09-29  2:00   ` Bryan Wu
2011-09-29  7:58   ` Russell King - ARM Linux
2011-09-29  7:58     ` Russell King - ARM Linux
2011-10-10 18:54 ` Anton Vorontsov [this message]
2011-10-10 18:54   ` Anton Vorontsov
2011-10-10 18:54   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111010185409.GA8787@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=akpm@google.com \
    --cc=bryan.wu@canonical.com \
    --cc=cjb@laptop.org \
    --cc=dwmw2@infradead.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=manuel.lauss@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.