From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>,
lrg@ti.com, kuninori.morimoto.gx@renesas.com,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH 2/9] ASoC: da7210: Add support for line input and mic
Date: Wed, 12 Oct 2011 15:53:10 +0100 [thread overview]
Message-ID: <20111012145310.GO3647@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318431492.12107.403.camel@matrix>
On Wed, Oct 12, 2011 at 08:28:12PM +0530, Ashish Chavan wrote:
> +static const char *da7210_mic_bias_voltage_txt[] = {
> + "1.5", "1.6", "2.2", "2.3"
> +};
> +
> +static const struct soc_enum da7210_mic_bias =
> + SOC_ENUM_SINGLE(DA7210_MIC_L, 4, 4, da7210_mic_bias_voltage_txt);
> +
This shouldn't be application controllable, it's a board property and if
it needs to be managed it's likely to be by in kernel things like
accessory detection. We do have some older drivers that do this but
they're not good. Use platform data.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg@ti.com, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
kuninori.morimoto.gx@renesas.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: da7210: Add support for line input and mic
Date: Wed, 12 Oct 2011 15:53:10 +0100 [thread overview]
Message-ID: <20111012145310.GO3647@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318431492.12107.403.camel@matrix>
On Wed, Oct 12, 2011 at 08:28:12PM +0530, Ashish Chavan wrote:
> +static const char *da7210_mic_bias_voltage_txt[] = {
> + "1.5", "1.6", "2.2", "2.3"
> +};
> +
> +static const struct soc_enum da7210_mic_bias =
> + SOC_ENUM_SINGLE(DA7210_MIC_L, 4, 4, da7210_mic_bias_voltage_txt);
> +
This shouldn't be application controllable, it's a board property and if
it needs to be managed it's likely to be by in kernel things like
accessory detection. We do have some older drivers that do this but
they're not good. Use platform data.
next prev parent reply other threads:[~2011-10-12 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 14:58 [PATCH 2/9] ASoC: da7210: Add support for line input and mic Ashish Chavan
2011-10-12 14:58 ` [alsa-devel] " Ashish Chavan
2011-10-12 14:53 ` Mark Brown [this message]
2011-10-12 14:53 ` Mark Brown
2011-10-13 8:55 ` Ashish Chavan
2011-10-13 8:55 ` Ashish Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012145310.GO3647@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.