All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hans J. Koch" <hjk@hansjkoch.de>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: linuxppc-dev@ozlabs.org, gregkh@suse.de,
	Kai Jiang <Kai.Jiang@freescale.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems
Date: Wed, 12 Oct 2011 18:19:31 +0200	[thread overview]
Message-ID: <20111012161931.GE21852@local> (raw)
In-Reply-To: <20111012153229.GB21852@local>

On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> > From: Kai Jiang <Kai.Jiang@freescale.com>
> > 
> > To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > embedded PPC, ARM, and X86 have support for systems with larger physical
> > address than logical.
> > 
> > Since 'addr' may contain a physical, logical, or virtual address the
> > easiest solution is to just change the type to 'unsigned long long'
> > regardless of which type is utilized.
> 
> No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
> Please use that.

I forgot: If you resend this, please update the documentation as well.
(Documentation/DocBook/uio-howto.tmpl)

Thanks,
Hans

WARNING: multiple messages have this Message-ID (diff)
From: "Hans J. Koch" <hjk@hansjkoch.de>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Kumar Gala <galak@kernel.crashing.org>,
	gregkh@suse.de, linuxppc-dev@ozlabs.org,
	linux-kernel@vger.kernel.org, Kai Jiang <Kai.Jiang@freescale.com>
Subject: Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems
Date: Wed, 12 Oct 2011 18:19:31 +0200	[thread overview]
Message-ID: <20111012161931.GE21852@local> (raw)
In-Reply-To: <20111012153229.GB21852@local>

On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
> > From: Kai Jiang <Kai.Jiang@freescale.com>
> > 
> > To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
> > extend the width of 'addr' in struct uio_mem.  Numerous platforms like
> > embedded PPC, ARM, and X86 have support for systems with larger physical
> > address than logical.
> > 
> > Since 'addr' may contain a physical, logical, or virtual address the
> > easiest solution is to just change the type to 'unsigned long long'
> > regardless of which type is utilized.
> 
> No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
> Please use that.

I forgot: If you resend this, please update the documentation as well.
(Documentation/DocBook/uio-howto.tmpl)

Thanks,
Hans


  parent reply	other threads:[~2011-10-12 16:19 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 14:35 [PATCH] uio: Support 36-bit physical addresses on 32-bit systems Kumar Gala
2011-10-12 14:35 ` Kumar Gala
2011-10-12 15:32 ` Hans J. Koch
2011-10-12 15:32   ` Hans J. Koch
2011-10-12 16:07   ` Kumar Gala
2011-10-12 16:07     ` Kumar Gala
2011-10-12 16:15     ` Geert Uytterhoeven
2011-10-12 16:15       ` Geert Uytterhoeven
2011-10-13 14:10       ` Tabi Timur-B04825
2011-10-13 14:10         ` Tabi Timur-B04825
2011-10-13 14:25         ` Geert Uytterhoeven
2011-10-13 14:25           ` Geert Uytterhoeven
2011-10-13 14:35           ` Timur Tabi
2011-10-13 14:35             ` Timur Tabi
2011-10-12 16:16     ` Hans J. Koch
2011-10-12 16:16       ` Hans J. Koch
2011-10-12 16:19   ` Hans J. Koch [this message]
2011-10-12 16:19     ` Hans J. Koch
2011-10-12 18:40     ` Kumar Gala
2011-10-12 18:40       ` Kumar Gala
2011-10-12 20:23       ` Hans J. Koch
2011-10-12 20:23         ` Hans J. Koch
2011-10-12 20:58         ` Kumar Gala
2011-10-12 20:58           ` Kumar Gala
  -- strict thread matches above, loose matches on Subject: below --
2011-10-13 15:50 Kumar Gala
2011-10-13 15:50 ` Kumar Gala
2011-10-14 18:31 ` Hans J. Koch
2011-10-14 18:31   ` Hans J. Koch
2011-10-14 18:36   ` Greg KH
2011-10-14 18:36     ` Greg KH
2011-10-14 18:46     ` Hans J. Koch
2011-10-14 18:46       ` Hans J. Koch
2011-10-17 16:00   ` Kumar Gala
2011-10-17 16:00     ` Kumar Gala
2011-10-17 17:18     ` Hans J. Koch
2011-10-17 17:18       ` Hans J. Koch
2011-10-17 18:03       ` Hans J. Koch
2011-10-17 18:03         ` Hans J. Koch
2011-10-17 18:23         ` Greg KH
2011-10-17 18:23           ` Greg KH
2011-10-17 18:50           ` Hans J. Koch
2011-10-17 18:50             ` Hans J. Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012161931.GE21852@local \
    --to=hjk@hansjkoch.de \
    --cc=Kai.Jiang@freescale.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.