From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read
Date: Thu, 13 Oct 2011 23:52:37 +0100 [thread overview]
Message-ID: <20111013225237.GA2952@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xWkVLNgToGiEn+xqgnii7QozNu0QAf2U-kXRNRtVK0dkqA@mail.gmail.com>
On Fri, Oct 14, 2011 at 06:39:43AM +0800, Axel Lin wrote:
> 2011/10/14 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > Probably the best thing here is to convert all these drivers to use
> > cache_bypass to read directly through the cache - the same thing will
> > then work with direct regmap usage.
> I don't complete understand "use cache_bypass to read directly through
> the cache".
Set the cache_bypass flag in the device struct.
> Or do you mean changes like below instead of calling regmap_read directly?
No, this isn't going to work. snd_soc_read() will use the cache.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read
Date: Thu, 13 Oct 2011 23:52:37 +0100 [thread overview]
Message-ID: <20111013225237.GA2952@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xWkVLNgToGiEn+xqgnii7QozNu0QAf2U-kXRNRtVK0dkqA@mail.gmail.com>
On Fri, Oct 14, 2011 at 06:39:43AM +0800, Axel Lin wrote:
> 2011/10/14 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > Probably the best thing here is to convert all these drivers to use
> > cache_bypass to read directly through the cache - the same thing will
> > then work with direct regmap usage.
> I don't complete understand "use cache_bypass to read directly through
> the cache".
Set the cache_bypass flag in the device struct.
> Or do you mean changes like below instead of calling regmap_read directly?
No, this isn't going to work. snd_soc_read() will use the cache.
next prev parent reply other threads:[~2011-10-13 22:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 7:22 [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap_read Axel Lin
2011-10-13 7:22 ` Axel Lin
2011-10-13 7:24 ` [PATCH 2/3] ASoC: tlv320aic3x: " Axel Lin
2011-10-13 7:25 ` [PATCH 3/3] ASoC: wm8961: " Axel Lin
2011-10-13 7:25 ` Axel Lin
2011-10-13 16:51 ` [PATCH 1/3] ASoC: alc5623: " Mark Brown
2011-10-13 22:39 ` Axel Lin
2011-10-13 22:39 ` Axel Lin
2011-10-13 22:52 ` Mark Brown [this message]
2011-10-13 22:52 ` Mark Brown
2011-10-13 23:29 ` Axel Lin
2011-10-13 23:29 ` Axel Lin
2011-10-13 23:34 ` Mark Brown
2011-10-13 23:34 ` Mark Brown
2011-10-13 23:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013225237.GA2952@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.