From: Pavel Roskin <proski@gnu.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
zajec5@gmail.com, b43-dev@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Convert to use crc8 code in kernel library
Date: Fri, 14 Oct 2011 11:11:03 -0400 [thread overview]
Message-ID: <20111014111103.5658d4aa@mj> (raw)
In-Reply-To: <4e90ce9a.89uGF659NNpbpyA3%Larry.Finger@lwfinger.net>
On Sat, 08 Oct 2011 17:28:42 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> +static inline void htol16_buf(u16 *buf, unsigned int size)
> +{
> + size /= 2;
> + while (size--)
> + *(__le16 *)(buf + size) = cpu_to_le16(*(buf + size));
> }
I'm not not sure compilers would optimize it out on little-endian
systems. Perhaps you want a define that uses this code on
big-endian systems and does nothing on little endian systems.
Also, it would be nice to have a compile-time check that size is even.
Or maybe size should be the number of 16-bit words, but then it would be
better to call the argument "count" or something like that.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-10-14 15:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 22:28 [PATCH] ssb: Convert to use crc8 code in kernel library Larry Finger
2011-10-08 22:38 ` Joe Perches
2011-10-08 23:00 ` Larry Finger
2011-10-08 23:00 ` Larry Finger
2011-10-08 23:11 ` Joe Perches
2011-10-08 22:51 ` Michael Büsch
2011-10-08 22:51 ` Michael Büsch
2011-10-09 8:48 ` Rafał Miłecki
2011-10-09 8:48 ` Rafał Miłecki
2011-10-09 10:33 ` Arend van Spriel
2011-10-09 14:35 ` Larry Finger
2011-10-09 14:35 ` Larry Finger
2011-10-09 9:50 ` Arend van Spriel
2011-10-14 15:11 ` Pavel Roskin [this message]
2011-10-14 15:30 ` Arend van Spriel
2011-10-14 16:30 ` Larry Finger
2011-10-14 16:30 ` Larry Finger
2011-10-14 16:47 ` Michael Büsch
2011-10-14 16:47 ` Michael Büsch
2011-10-15 8:27 ` Arend van Spriel
2011-10-15 13:29 ` Larry Finger
2011-10-15 13:29 ` Larry Finger
2011-10-15 13:53 ` Michael Büsch
2011-10-15 13:53 ` Michael Büsch
2011-10-15 14:18 ` Larry Finger
2011-10-15 14:18 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014111103.5658d4aa@mj \
--to=proski@gnu.org \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.