All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Pavel Roskin <proski@gnu.org>,
	John W Linville <linville@tuxdriver.com>,
	Michael Buesch <mb@bu3sch.de>,
	"zajec5@gmail.com" <zajec5@gmail.com>,
	"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: [PATCH] ssb: Convert to use crc8 code in kernel library
Date: Sat, 15 Oct 2011 08:29:05 -0500	[thread overview]
Message-ID: <4E998AA1.4080907@lwfinger.net> (raw)
In-Reply-To: <4E9943D5.1060607@broadcom.com>

On 10/15/2011 03:27 AM, Arend van Spriel wrote:
>
> Feedback on the renaming is indeed valid. Passing the word count is
> better here. For brcmsmac I plan to fill the buffer using 8-bit reads
> from SPROM, verify the crc8, and perform the endianess conversion from
> le16 to cpu when crc is ok (actually under review internally).

That sounds like a good plan. When that is posted, I'll study if that kind of 
change makes sense for ssb.

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Pavel Roskin <proski@gnu.org>,
	John W Linville <linville@tuxdriver.com>,
	Michael Buesch <mb@bu3sch.de>,
	"zajec5@gmail.com" <zajec5@gmail.com>,
	"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ssb: Convert to use crc8 code in kernel library
Date: Sat, 15 Oct 2011 08:29:05 -0500	[thread overview]
Message-ID: <4E998AA1.4080907@lwfinger.net> (raw)
In-Reply-To: <4E9943D5.1060607@broadcom.com>

On 10/15/2011 03:27 AM, Arend van Spriel wrote:
>
> Feedback on the renaming is indeed valid. Passing the word count is
> better here. For brcmsmac I plan to fill the buffer using 8-bit reads
> from SPROM, verify the crc8, and perform the endianess conversion from
> le16 to cpu when crc is ok (actually under review internally).

That sounds like a good plan. When that is posted, I'll study if that kind of 
change makes sense for ssb.

Larry


  reply	other threads:[~2011-10-15 13:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-08 22:28 [PATCH] ssb: Convert to use crc8 code in kernel library Larry Finger
2011-10-08 22:38 ` Joe Perches
2011-10-08 23:00   ` Larry Finger
2011-10-08 23:00     ` Larry Finger
2011-10-08 23:11     ` Joe Perches
2011-10-08 22:51 ` Michael Büsch
2011-10-08 22:51   ` Michael Büsch
2011-10-09  8:48   ` Rafał Miłecki
2011-10-09  8:48     ` Rafał Miłecki
2011-10-09 10:33     ` Arend van Spriel
2011-10-09 14:35     ` Larry Finger
2011-10-09 14:35       ` Larry Finger
2011-10-09  9:50   ` Arend van Spriel
2011-10-14 15:11 ` Pavel Roskin
2011-10-14 15:30   ` Arend van Spriel
2011-10-14 16:30   ` Larry Finger
2011-10-14 16:30     ` Larry Finger
2011-10-14 16:47     ` Michael Büsch
2011-10-14 16:47       ` Michael Büsch
2011-10-15  8:27     ` Arend van Spriel
2011-10-15 13:29       ` Larry Finger [this message]
2011-10-15 13:29         ` Larry Finger
2011-10-15 13:53         ` Michael Büsch
2011-10-15 13:53           ` Michael Büsch
2011-10-15 14:18           ` Larry Finger
2011-10-15 14:18             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E998AA1.4080907@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=proski@gnu.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.