From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dario Faggioli <raistlin@linux.it>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
xen-devel <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH] xen/gntdev: Fix sleep-inside-spinlock
Date: Fri, 14 Oct 2011 09:54:59 -0400 [thread overview]
Message-ID: <20111014135459.GA4577@phenom.oracle.com> (raw)
In-Reply-To: <1318586226.5062.21.camel@Palantir>
On Fri, Oct 14, 2011 at 11:57:05AM +0200, Dario Faggioli wrote:
> On Tue, 2011-10-11 at 15:16 -0400, Daniel De Graaf wrote:
> > gntdev_put_map tries to acquire a mutex when freeing pages back to the
> > xenballoon pool, so it cannot be called with a spinlock held. In
> > gntdev_release, the spinlock is not needed as we are freeing the
> > structure later; in the ioctl, only the list manipulation needs to be
> > under the lock.
> >
> > Reported-By: Dario Faggioli <raistlin@linux.it>
> > Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> >
> Ok, I finally manage in testing this, and it actually cures the issue
> here!
>
> You can add a tested-by tag if you like. Just, if you don't mind, use my
> corp. e-mail for (both?) the tag(s): <dario.faggioli@citrix.com>
Sure. Thx for checking it.
prev parent reply other threads:[~2011-10-14 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 17:13 BUG: sleeping function called from invalid context Dario Faggioli
2011-10-11 17:32 ` Konrad Rzeszutek Wilk
2011-10-11 19:16 ` [PATCH] xen/gntdev: Fix sleep-inside-spinlock Daniel De Graaf
2011-10-13 15:40 ` Konrad Rzeszutek Wilk
2011-10-13 16:26 ` Dario Faggioli
2011-10-14 11:18 ` Dario Faggioli
2011-10-14 9:57 ` Dario Faggioli
2011-10-14 13:54 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014135459.GA4577@phenom.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=raistlin@linux.it \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.