From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
Cc: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
Arjan van de Ven <arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>,
lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org,
harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
david-o55+BOBDEFg@public.gmane.org,
greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH, v10 3/3] cgroups: introduce timer slack controller
Date: Fri, 14 Oct 2011 15:43:48 -0700 [thread overview]
Message-ID: <20111014154348.ae6267aa.akpm@linux-foundation.org> (raw)
In-Reply-To: <1318349729-3108-4-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
On Tue, 11 Oct 2011 19:15:29 +0300
"Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> wrote:
> Every task_struct has timer_slack_ns value. This value uses to round up
> poll() and select() timeout values. This feature can be useful in
> mobile environment where combined wakeups are desired.
>
> Originally, prctl() was the only way to change timer slack value of
> a process. So you was not able change timer slack value of another
> process.
>
> cgroup subsys "timer_slack" implements timer slack controller. It
> provides a way to set minimal timer slack value for a group of tasks.
> If a task belongs to a cgroup with minimal timer slack value higher than
> task's value, cgroup's value will be applied.
>
> Timer slack controller allows to implement setting timer slack value of
> a process based on a policy. For example, you can create foreground and
> background cgroups and move tasks between them based on system state.
I'm having trouble understanding the value of this feature. Users can
presently control the timer-slack of a group of processes via
inherit-over-fork.
Perhaps there's a case for providing a way for process A to set process
B's slack. And perhaps B's children. That would be a simpler patch
and would have the considerable advantage that it doesn't require
cgroups.
So.... why should we merge this?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>,
containers@lists.linux-foundation.org,
jacob.jun.pan@linux.intel.com,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
linux-api@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
lennart@poettering.net, harald@redhat.com, david@fubar.dk,
greg@kroah.com
Subject: Re: [PATCH, v10 3/3] cgroups: introduce timer slack controller
Date: Fri, 14 Oct 2011 15:43:48 -0700 [thread overview]
Message-ID: <20111014154348.ae6267aa.akpm@linux-foundation.org> (raw)
In-Reply-To: <1318349729-3108-4-git-send-email-kirill@shutemov.name>
On Tue, 11 Oct 2011 19:15:29 +0300
"Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> Every task_struct has timer_slack_ns value. This value uses to round up
> poll() and select() timeout values. This feature can be useful in
> mobile environment where combined wakeups are desired.
>
> Originally, prctl() was the only way to change timer slack value of
> a process. So you was not able change timer slack value of another
> process.
>
> cgroup subsys "timer_slack" implements timer slack controller. It
> provides a way to set minimal timer slack value for a group of tasks.
> If a task belongs to a cgroup with minimal timer slack value higher than
> task's value, cgroup's value will be applied.
>
> Timer slack controller allows to implement setting timer slack value of
> a process based on a policy. For example, you can create foreground and
> background cgroups and move tasks between them based on system state.
I'm having trouble understanding the value of this feature. Users can
presently control the timer-slack of a group of processes via
inherit-over-fork.
Perhaps there's a case for providing a way for process A to set process
B's slack. And perhaps B's children. That would be a simpler patch
and would have the considerable advantage that it doesn't require
cgroups.
So.... why should we merge this?
next prev parent reply other threads:[~2011-10-14 22:43 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 16:15 [PATCH, v10 0/3] Introduce timer slack controller Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 1/3] hrtimer: introduce effective timer slack Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 2/3] hrtimer: implement PR_GET_EFFECTIVE_TIMERSLACK Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 3/3] cgroups: introduce timer slack controller Kirill A. Shutemov
[not found] ` <1318349729-3108-4-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-10-11 16:49 ` Kirill A. Shutemov
2011-10-11 16:49 ` Kirill A. Shutemov
2011-10-14 22:43 ` Andrew Morton [this message]
2011-10-14 22:43 ` Andrew Morton
[not found] ` <20111014154348.ae6267aa.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2011-10-14 23:34 ` Kirill A. Shutemov
2011-10-14 23:34 ` Kirill A. Shutemov
2011-10-15 11:20 ` Lennart Poettering
2011-10-15 19:11 ` Peter Zijlstra
2011-10-17 1:39 ` Lennart Poettering
2011-10-17 1:39 ` Lennart Poettering
[not found] ` <20111017013921.GA30035-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2011-10-17 3:22 ` Matthew Garrett
2011-10-17 3:22 ` Matthew Garrett
[not found] ` <20111017032232.GA4816-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-10-17 5:21 ` Arjan van de Ven
2011-10-17 5:21 ` Arjan van de Ven
[not found] ` <4E9BBB6D.4050004-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2011-10-17 7:36 ` Peter Zijlstra
2011-10-17 7:36 ` Peter Zijlstra
2011-10-17 9:38 ` Thomas Gleixner
2011-10-17 9:38 ` Thomas Gleixner
2011-10-17 12:46 ` Matthew Garrett
2011-10-17 12:46 ` Matthew Garrett
[not found] ` <20111017124647.GA12838-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-10-17 13:06 ` Peter Zijlstra
2011-10-17 13:06 ` Peter Zijlstra
2011-10-17 14:11 ` Matthew Garrett
[not found] ` <20111017141147.GA14581-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-10-17 14:28 ` Peter Zijlstra
2011-10-17 14:28 ` Peter Zijlstra
2011-10-17 14:35 ` Arjan van de Ven
[not found] ` <4E9C3D39.9020109-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2011-10-17 14:45 ` Peter Zijlstra
2011-10-17 14:45 ` Peter Zijlstra
2011-10-17 14:40 ` Matthew Garrett
2011-10-17 14:40 ` Matthew Garrett
2011-10-17 14:49 ` Peter Zijlstra
2011-10-17 14:59 ` Matthew Garrett
2011-10-17 14:59 ` Matthew Garrett
2011-10-17 15:11 ` Peter Zijlstra
2011-10-17 15:19 ` Matthew Garrett
2011-10-17 15:19 ` Matthew Garrett
[not found] ` <20111017151920.GA16664-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-10-17 15:21 ` Peter Zijlstra
2011-10-17 15:21 ` Peter Zijlstra
2011-10-17 15:31 ` Matthew Garrett
2011-10-17 15:31 ` Matthew Garrett
[not found] ` <20111017153142.GA17047-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2011-10-17 16:36 ` Peter Zijlstra
2011-10-17 16:36 ` Peter Zijlstra
2011-10-17 16:49 ` Matthew Garrett
2011-10-17 16:49 ` Matthew Garrett
2011-10-17 15:48 ` Alan Cox
2011-10-17 15:48 ` Alan Cox
[not found] ` <20111017164839.3887ee3e-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2011-10-17 16:33 ` Peter Zijlstra
2011-10-17 16:33 ` Peter Zijlstra
2011-10-17 15:18 ` Peter Zijlstra
2011-10-17 15:18 ` Peter Zijlstra
2011-10-17 7:34 ` Peter Zijlstra
2011-10-17 13:55 ` Lennart Poettering
2011-10-17 7:28 ` Peter Zijlstra
2011-10-17 7:28 ` Peter Zijlstra
2011-10-17 19:46 ` Valdis.Kletnieks-PjAqaU27lzQ
2011-10-17 19:46 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014154348.ae6267aa.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=david-o55+BOBDEFg@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
--cc=kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org \
--cc=lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.