All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: Axel Lin <axel.lin@gmail.com>, Liam Girdwood <lrg@ti.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: max98095: Convert codec->hw_write to snd_soc_write
Date: Fri, 14 Oct 2011 20:03:42 +0100	[thread overview]
Message-ID: <20111014190342.GA2931@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40DDFD2E54E@ITSVLEX06.it.maxim-ic.internal>

On Fri, Oct 14, 2011 at 10:40:58AM -0700, Peter Hsiang wrote:
> On Fri, Oct 14, 2011, Axel Lin wrote:
> > codec->hw_write is broken now, convert codec->hw_write to
> > snd_soc_write.

> The hardware has 2 banks of registers sharing a section in I2C register space.
> The 1st bank is the primary one and is cached.  
> The 2nd bank is for loading coefficients only and they do not need cache.
> These coefficients registers are therefore direct writes.
> Changing this to a cached write will overwrite the cache.

Writes to the cached region should be done within a cache_bypass flag to
deal with this.

      reply	other threads:[~2011-10-14 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14  3:43 [PATCH] ASoC: max98095: Convert codec->hw_write to snd_soc_write Axel Lin
2011-10-14  3:43 ` Axel Lin
2011-10-14 17:40 ` Peter Hsiang
2011-10-14 17:40   ` Peter Hsiang
2011-10-14 19:03   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111014190342.GA2931@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=Peter.Hsiang@maxim-ic.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.