From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.
Date: Sun, 16 Oct 2011 01:15:58 -0400 [thread overview]
Message-ID: <201110160115.59515.vapier@gentoo.org> (raw)
In-Reply-To: <CAC3GErG2-ED3iKZ+dg7pJMh8osfHKuq9E1Ncrbov8EfB+F6SFA@mail.gmail.com>
On Saturday 15 October 2011 16:27:02 Vadim Bendebury wrote:
> On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote:
> >> Vadim Bendebury wrote:
> >> > > Two underscores aren't a good practice.
> >> >
> >> > I did this as a result of a previous review. Do you have a suggestion
> >> > how this should be done instead?
> >>
> >> First, and most important, __u_boot_cmd_tpm appears to be undefined in
> >> your two patches, so it looks to be a real bug.
> >>
> >> Second, please read the C standard's section about reserved
> >> identifiers.
> >
> > no, this is coming from common u-boot code. look at
> > include/command.h:U_BOOT_CMD defines.
>
> or, more importantly: the question is what is the right/suggested way
> to print out the help message associated with a U_BOOT_CMD
> declaration?
your command is given a cmd_tbl_t *cmdtp pointer to pass to cmd_usage
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111016/2ef767da/attachment.pgp
next prev parent reply other threads:[~2011-10-16 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 3:39 [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device Vadim Bendebury
2011-10-15 18:02 ` Marek Vasut
2011-10-15 18:23 ` Vadim Bendebury
2011-10-15 19:44 ` Wolfgang Denk
2011-10-15 20:01 ` Mike Frysinger
2011-10-15 20:27 ` Vadim Bendebury
2011-10-16 5:15 ` Mike Frysinger [this message]
2011-10-16 0:58 ` Vadim Bendebury
2011-10-15 19:08 ` Mike Frysinger
2011-10-16 0:56 ` Vadim Bendebury
2011-10-15 19:13 ` Mike Frysinger
2011-10-15 19:14 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110160115.59515.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.