From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH 3.2] b43: fill ctl1 word on all new PHYs, fix PHY errors
Date: Mon, 17 Oct 2011 16:24:47 +0200 [thread overview]
Message-ID: <20111017162447.5a758fda@milhouse> (raw)
In-Reply-To: <1318800236-5329-1-git-send-email-zajec5@gmail.com>
On Sun, 16 Oct 2011 23:23:56 +0200
Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> + if (phy->type >= B43_PHYTYPE_N) {
I must say that I really dislike this. It's error prone (previous patch got it wrong)
and it's hard to read. Just spell out all types or use a switch statement, as appropriate.
It also makes grepping the sources a lot harder.
I don't see any real advantage.
--
Greetings, Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 3.2] b43: fill ctl1 word on all new PHYs, fix PHY errors
Date: Mon, 17 Oct 2011 16:24:47 +0200 [thread overview]
Message-ID: <20111017162447.5a758fda@milhouse> (raw)
In-Reply-To: <1318800236-5329-1-git-send-email-zajec5@gmail.com>
On Sun, 16 Oct 2011 23:23:56 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> + if (phy->type >= B43_PHYTYPE_N) {
I must say that I really dislike this. It's error prone (previous patch got it wrong)
and it's hard to read. Just spell out all types or use a switch statement, as appropriate.
It also makes grepping the sources a lot harder.
I don't see any real advantage.
--
Greetings, Michael.
next prev parent reply other threads:[~2011-10-17 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 21:23 [PATCH 3.2] b43: fill ctl1 word on all new PHYs, fix PHY errors Rafał Miłecki
2011-10-16 21:23 ` Rafał Miłecki
2011-10-17 14:24 ` Michael Büsch [this message]
2011-10-17 14:24 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017162447.5a758fda@milhouse \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.