From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/samsung: Complain loudly if we don't know the SoC
Date: Mon, 17 Oct 2011 22:33:03 +0100 [thread overview]
Message-ID: <20111017213303.GA3366@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACxGe6vqUjayFVu1wNUYN_zjngKJcXkzzcxcGn4bwkHG7xv2yg@mail.gmail.com>
On Mon, Oct 17, 2011 at 03:07:47PM -0600, Grant Likely wrote:
> On Mon, Oct 17, 2011 at 3:04 PM, Mark Brown
> > If we don't know the SoC type then we won't add any chips which is rather
> > unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of
> > different subsystems. Logging at least provides a hint to the user as to
> > what's gone wrong.
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Be Bolder! May as well use WARN() and be really obnoxious. :-)
Actually what's really unfortunate here is that in most configurations
this will cause a catastrophic failure to boot so we never get far
enough to see the logging at all. We really need aSCREAM_THROUGH_DEBUG_LL()
or whatever. Or to fix these things to dump via that route if we don't
have the console up yet, which is going to be more practical.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Grant Likely <grant@secretlab.ca>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] gpio/samsung: Complain loudly if we don't know the SoC
Date: Mon, 17 Oct 2011 22:33:03 +0100 [thread overview]
Message-ID: <20111017213303.GA3366@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACxGe6vqUjayFVu1wNUYN_zjngKJcXkzzcxcGn4bwkHG7xv2yg@mail.gmail.com>
On Mon, Oct 17, 2011 at 03:07:47PM -0600, Grant Likely wrote:
> On Mon, Oct 17, 2011 at 3:04 PM, Mark Brown
> > If we don't know the SoC type then we won't add any chips which is rather
> > unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of
> > different subsystems. Logging at least provides a hint to the user as to
> > what's gone wrong.
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Be Bolder! May as well use WARN() and be really obnoxious. :-)
Actually what's really unfortunate here is that in most configurations
this will cause a catastrophic failure to boot so we never get far
enough to see the logging at all. We really need aSCREAM_THROUGH_DEBUG_LL()
or whatever. Or to fix these things to dump via that route if we don't
have the console up yet, which is going to be more practical.
next prev parent reply other threads:[~2011-10-17 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 21:04 [PATCH] gpio/samsung: Complain loudly if we don't know the SoC Mark Brown
2011-10-17 21:04 ` Mark Brown
2011-10-17 21:07 ` Grant Likely
2011-10-17 21:07 ` Grant Likely
2011-10-17 21:33 ` Mark Brown [this message]
2011-10-17 21:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017213303.GA3366@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.