Re: [PATCH 3/3] spi/pl022: skip default configuration before suspending

[Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>]

On Tue, Oct 18, 2011 at 02:43:34PM +0530, Viresh Kumar wrote:
> On 10/17/2011 6:42 PM, Linus WALLEIJ wrote:
> > From: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
> > 
> > The loading of the default configuration before suspending has
> > been in the driver since its inception, but it is not really
> > needed. Especially so since we take to all the trouble of
> > enabling and disabling power and clock just to do this. Let's
> > scrap this now.
> > 
> > Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
> > Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >  drivers/spi/spi-pl022.c |    5 -----
> >  1 files changed, 0 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> > index 0a1d8ed..29dc70f 100644
> > --- a/drivers/spi/spi-pl022.c
> > +++ b/drivers/spi/spi-pl022.c
> > @@ -2342,11 +2342,6 @@ static int pl022_suspend(struct amba_device *adev, pm_message_t state)
> >  		return status;
> >  	}
> >  
> > -	amba_vcore_enable(adev);
> > -	amba_pclk_enable(adev);
> > -	load_ssp_default_config(pl022);
> > -	amba_pclk_disable(adev);
> > -	amba_vcore_disable(adev);
> >  	dev_dbg(&adev->dev, "suspended\n");
> >  	return 0;
> >  }
> 
> Reviewed-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>

This definitely conflicts with patches I have queued for this window.

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct