All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com>
Subject: [RFC] mac80211: properly go back to operational channel?
Date: Tue, 18 Oct 2011 16:19:22 +0200	[thread overview]
Message-ID: <20111018141922.GA6204@redhat.com> (raw)
In-Reply-To: <1317813762.4839.7.camel@jlt3.sipsolutions.net>

For local->tmp_channel == NULL and local->scan_channel == NULL
ieee80211_cfg_on_oper_channel() will return false if
local->oper_channel != local->hw.conf.channel,
hece we do not properly go back to oper_channel from tmp_channel.

Does patch have sense? Could it fixes problems we are talking
in this thread?

diff --git a/net/mac80211/work.c b/net/mac80211/work.c
index af374fa..98bf1fa 100644
--- a/net/mac80211/work.c
+++ b/net/mac80211/work.c
@@ -1101,7 +1101,7 @@ static void ieee80211_work_work(struct work_struct *work)
 		 * we still need to do a hardware config.  Currently,
 		 * we cannot be here while scanning, however.
 		 */
-		if (ieee80211_cfg_on_oper_channel(local) && !on_oper_chan)
+		if (!on_oper_chan)
 			ieee80211_hw_config(local, 0);
 
 		/* At the least, we need to disable offchannel_ps,

  reply	other threads:[~2011-10-18 14:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 11:12 [RFC] mac80211: remove per band sta supported rates Stanislaw Gruszka
2011-09-27 11:34 ` Johannes Berg
2011-09-29 15:00   ` Stanislaw Gruszka
2011-10-04 15:07     ` Johannes Berg
2011-10-05 11:15       ` Stanislaw Gruszka
2011-10-05 11:22         ` Johannes Berg
2011-10-18 14:19           ` Stanislaw Gruszka [this message]
2011-10-18 14:30             ` [RFC] mac80211: properly go back to operational channel? Johannes Berg
2011-10-18 14:53               ` Felix Fietkau
2011-10-18 16:03                 ` Ben Greear
2011-10-19 18:48               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111018141922.GA6204@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.