From: Steffen Klassert <steffen.klassert@secunet.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] route:ip_rt_frag_needed always return unzero
Date: Wed, 19 Oct 2011 10:38:32 +0200 [thread overview]
Message-ID: <20111019083832.GT1830@secunet.com> (raw)
In-Reply-To: <4E9E8552.1050405@cn.fujitsu.com>
On Wed, Oct 19, 2011 at 04:07:46PM +0800, Gao feng wrote:
> 2011.10.19 15:26, Steffen Klassert wrote:
>
> >
> > It is valid in the sense that we should not provide the user
> > with a mtu information if we know that the value we got from
> > the icmp packet ist bogus. But perhaps we can think about
> > making the check for a valid mtu unconditionally and let
> > ip_rt_frag_needed return a valid mtu in any case.
> >
> >
>
> I think we should return the pmtu in icmp packet to the raw socket,
> and the valid mtu to tcp_v4_err or something else.
>
Why you want to handle raw sockets different here?
next prev parent reply other threads:[~2011-10-19 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 7:04 [PATCH] route:ip_rt_frag_needed always return unzero Gao feng
2011-10-18 9:23 ` Eric Dumazet
2011-10-19 1:34 ` Gao feng
2011-10-19 2:33 ` Gao feng
2011-10-19 3:57 ` Eric Dumazet
2011-10-19 3:49 ` Eric Dumazet
2011-10-19 5:20 ` Gao feng
2011-10-19 5:47 ` Eric Dumazet
2011-10-19 6:36 ` Gao feng
2011-10-19 7:26 ` Steffen Klassert
2011-10-19 8:07 ` Gao feng
2011-10-19 8:38 ` Steffen Klassert [this message]
2011-10-19 8:59 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019083832.GT1830@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.