From: Gao feng <gaofeng@cn.fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] route:ip_rt_frag_needed always return unzero
Date: Wed, 19 Oct 2011 14:36:47 +0800 [thread overview]
Message-ID: <4E9E6FFF.80802@cn.fujitsu.com> (raw)
In-Reply-To: <1319003231.16303.2.camel@edumazet-laptop>
2011.10.19 13:47, Eric Dumazet wrote:
> Le mercredi 19 octobre 2011 à 13:20 +0800, Gao feng a écrit :
>
>> In orig ip_rt_frag_need,
>> zero can be return only when pmtu(get from icmp packet) is zero and peer is NULL.
>> in this case,raw_icmp_error will not be call too.this is valid??
>
> I dont know, tell me.
>
> I am afraid you're adding a possible regression here.
>
> pmtu from icmp_packet is not zero in the common case.
>
>
AS raw socket is special,I think it's should call raw_icmp_error even the icmp packet is invalid.
if I am right,I think it's another BUG.
next prev parent reply other threads:[~2011-10-19 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 7:04 [PATCH] route:ip_rt_frag_needed always return unzero Gao feng
2011-10-18 9:23 ` Eric Dumazet
2011-10-19 1:34 ` Gao feng
2011-10-19 2:33 ` Gao feng
2011-10-19 3:57 ` Eric Dumazet
2011-10-19 3:49 ` Eric Dumazet
2011-10-19 5:20 ` Gao feng
2011-10-19 5:47 ` Eric Dumazet
2011-10-19 6:36 ` Gao feng [this message]
2011-10-19 7:26 ` Steffen Klassert
2011-10-19 8:07 ` Gao feng
2011-10-19 8:38 ` Steffen Klassert
2011-10-19 8:59 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9E6FFF.80802@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.