From: Borislav Petkov <bp@amd64.org>
To: David Rientjes <rientjes@google.com>
Cc: EDAC devel <linux-edac@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@elte.hu>,
X86-ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection
Date: Thu, 20 Oct 2011 17:06:05 +0200 [thread overview]
Message-ID: <20111020150605.GH12080@aftab> (raw)
In-Reply-To: <alpine.DEB.2.00.1110191415120.5687@chino.kir.corp.google.com>
On Wed, Oct 19, 2011 at 05:19:06PM -0400, David Rientjes wrote:
> On Wed, 19 Oct 2011, Borislav Petkov wrote:
>
> > > That wouldn't catch an offline cpuid, you probably want cpu_online(val)?
> >
> > Good catch, thanks.
> >
> > So I'm looking at <arch/x86/kernel/cpuid.c> which is how the validity of
> > a cpu value should be tested properly, IMHO:
> >
> > static int cpuid_open(struct inode *inode, struct file *file)
> > {
> > ...
> >
> > if (cpu >= nr_cpu_ids || !cpu_online(cpu))
> > return -ENXIO; /* No such CPU */
> > ...
>
> Right, the comment for cpumask_test_cpu(), which cpu_online() really is,
> wants a cpu < nr_cpu_ids.
Fixed, thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2011-10-20 15:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 14:50 [RFC -v2] x86 RAS: Reorganize functionality Borislav Petkov
2011-10-19 14:50 ` [PATCH 1/9] x86, mce: Enable MCA support by default Borislav Petkov
2011-10-19 14:50 ` [PATCH 2/9] x86, RAS: Start reorganizing RAS features support Borislav Petkov
2011-10-19 17:13 ` Luck, Tony
2011-10-19 17:22 ` Mauro Carvalho Chehab
2011-10-19 18:11 ` Borislav Petkov
2011-10-19 19:14 ` Mauro Carvalho Chehab
2011-10-20 15:12 ` Borislav Petkov
2011-10-19 14:51 ` [PATCH 3/9] x86, RAS: Move MCE decoding code into ras/ Borislav Petkov
2011-10-19 14:51 ` [PATCH 4/9] x86, RAS: Move MCE injection " Borislav Petkov
2011-10-19 14:51 ` [PATCH 5/9] x86, MCE: Add a HW injection flag Borislav Petkov
2011-10-19 14:51 ` [PATCH 6/9] x86, RAS: Convert mce-inject module to debugfs Borislav Petkov
2011-10-19 14:51 ` [PATCH 7/9] x86, RAS: Add function enabling direct writes to MCE MSRs Borislav Petkov
2011-10-19 14:51 ` [PATCH 8/9] x86, RAS: Add attributes needed for HW injection Borislav Petkov
2011-10-19 21:03 ` David Rientjes
2011-10-19 21:09 ` Borislav Petkov
2011-10-19 21:19 ` David Rientjes
2011-10-20 15:06 ` Borislav Petkov [this message]
2011-10-19 14:51 ` [PATCH 9/9] x86, RAS: Add an injector function Borislav Petkov
2011-10-19 17:08 ` [RFC -v2] x86 RAS: Reorganize functionality Luck, Tony
2011-10-19 17:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020150605.GH12080@aftab \
--to=bp@amd64.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.