From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: "Girdwood, Liam" <lrg@ti.com>,
alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC
Date: Fri, 21 Oct 2011 10:00:55 +0100 [thread overview]
Message-ID: <20111021090054.GF3513@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1319186260.24621.154.camel@matrix>
On Fri, Oct 21, 2011 at 02:07:40PM +0530, Ashish Chavan wrote:
> On Thu, 2011-10-20 at 18:10 +0100, Girdwood, Liam wrote:
> > Any reason for not using DAPM here ? Otherwise they are always on
> > making your chip burn mW.....
> Not really. As explained in the comment in DAPM patch, this enables will
> be effective (burn mW) only after respective IO is taken out from
> STANDBY mode. DAPM takes care of managing STANDBY mode for all IOs and
> ADC/DAC. I know this way of handling low power mode is bit non-trivial,
> but it is what is recommended by chip designers. Actually Mark was also
> initially confused with this and requested to put enough documentation
> into code. After that I tried explaining the logic in source code
> comment in DAPM patch. Let me know if it is not clear and doesn't convey
> clearly what is should.
That'd be fine but there's no DAPM code in the patch, only code to
unconditionally enable on init.
next prev parent reply other threads:[~2011-10-21 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 14:42 [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC Ashish Chavan
2011-10-20 17:10 ` [alsa-devel] " Girdwood, Liam
2011-10-21 8:37 ` Ashish Chavan
2011-10-21 9:00 ` Mark Brown [this message]
2011-10-21 9:49 ` Ashish Chavan
2011-10-21 10:24 ` Mark Brown
2011-10-21 10:24 ` [alsa-devel] " Mark Brown
2011-10-21 11:05 ` Ashish Chavan
2011-10-21 11:12 ` Mark Brown
2011-10-21 11:12 ` [alsa-devel] " Mark Brown
2011-10-21 11:32 ` Ashish Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021090054.GF3513@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.