All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	alsa-devel <alsa-devel@alsa-project.org>,
	"Girdwood, Liam" <lrg@ti.com>,
	"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
	David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC
Date: Fri, 21 Oct 2011 11:24:30 +0100	[thread overview]
Message-ID: <20111021102429.GB4080@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1319190555.24621.160.camel@matrix>

On Fri, Oct 21, 2011 at 03:19:15PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 10:00 +0100, Mark Brown wrote:

> > That'd be fine but there's no DAPM code in the patch, only code to
> > unconditionally enable on init.

> Yes, because DAPM part for those IOs is already covered by DAPM patch.

Ah, you should split that out of the DAPM patch into here - the DAPM bit
won't work without the enable bits (as I understand it).

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: "Girdwood, Liam" <lrg@ti.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	David Dajun Chen <david.chen@diasemi.com>,
	"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC
Date: Fri, 21 Oct 2011 11:24:30 +0100	[thread overview]
Message-ID: <20111021102429.GB4080@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1319190555.24621.160.camel@matrix>

On Fri, Oct 21, 2011 at 03:19:15PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 10:00 +0100, Mark Brown wrote:

> > That'd be fine but there's no DAPM code in the patch, only code to
> > unconditionally enable on init.

> Yes, because DAPM part for those IOs is already covered by DAPM patch.

Ah, you should split that out of the DAPM patch into here - the DAPM bit
won't work without the enable bits (as I understand it).

  reply	other threads:[~2011-10-21 10:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 14:42 [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC Ashish Chavan
2011-10-20 17:10 ` [alsa-devel] " Girdwood, Liam
2011-10-21  8:37   ` Ashish Chavan
2011-10-21  9:00     ` [alsa-devel] " Mark Brown
2011-10-21  9:49       ` Ashish Chavan
2011-10-21 10:24         ` Mark Brown [this message]
2011-10-21 10:24           ` [alsa-devel] " Mark Brown
2011-10-21 11:05           ` Ashish Chavan
2011-10-21 11:12             ` Mark Brown
2011-10-21 11:12               ` [alsa-devel] " Mark Brown
2011-10-21 11:32               ` Ashish Chavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111021102429.GB4080@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ashish.chavan@kpitcummins.com \
    --cc=david.chen@diasemi.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.