All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/kms: Make i2c buses faster
Date: Fri, 21 Oct 2011 16:16:28 +0200	[thread overview]
Message-ID: <201110211616.28511.jdelvare@suse.de> (raw)
In-Reply-To: <20111021143244.4d1eac1e@lxorguk.ukuu.org.uk>

Hi Alan,

On Friday 21 October 2011 03:32:44 pm Alan Cox wrote:
> On Fri, 21 Oct 2011 09:08:30 +0200
> 
> Jean Delvare <jdelvare@suse.de> wrote:
> > A udelay value of 20 leads to an I2C bus running at only 25 kbps. A
> > value of 40 as the nouveau driver has is even slower at 12.5 kbps.
> > I2C devices can typically operate faster than this, 50 kbps should
> > be fine for all devices (and compliant devices can always stretch
> > the clock is needed.)
> 
> That depends on your cable, drive and signal quality. It's not
>  something you just turn up because it seems a good idea. Reliability
>  is MUCH more important than shaving microseconds off monitor probe
>  times.

We're talking milliseconds here, not microseconds. Namely 23 ms per 128-
byte EDID block for intel and radeon, 69 ms for nouveau.

I very much doubt that cable quality is an issue here. DDC is a very 
slow bus (even at the maximum speed of 100 kbps) compared to the video 
signal which is running through the other wires in the VGA or DDC cable. 
If you really reach the point where DDC becomes unreliable, I doubt the 
video signal is anywhere next to usable.

More importantly, my initial motivation for sending this patch is that 
it may help prevent problems due to the software nature of bit-banged 
I2C. A faster clock means shorter (time-wise) messages, which in turn 
means less risks to be disturbed by interrupts or CPU overload.

Last but not least, I can't believe that so many framebuffer drivers 
would have been using these settings for years if it caused trouble.

Does anyone know at which speed hardware I2C engines are running the DDC 
bus on various graphics cards?

-- 
Jean Delvare
Suse L3

  reply	other threads:[~2011-10-21 14:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  7:08 [PATCH 1/2] drm/kms: Make i2c buses faster Jean Delvare
2011-10-21 13:32 ` Alan Cox
2011-10-21 14:16   ` Jean Delvare [this message]
2011-10-21 18:05     ` Alex Deucher
2011-10-21 19:29       ` Jean Delvare
2011-10-22 14:38         ` Alex Deucher
2011-10-24 14:19           ` Eugeni Dodonov
  -- strict thread matches above, loose matches on Subject: below --
2012-01-28 10:07 Jean Delvare
2012-01-28 14:46 ` Alex Deucher
2012-01-29  1:26 ` Keith Packard
2012-03-21 10:45   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110211616.28511.jdelvare@suse.de \
    --to=jdelvare@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.