All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: dri-devel@lists.freedesktop.org
Cc: Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: [PATCH 1/2] drm/kms: Make i2c buses faster
Date: Sat, 28 Jan 2012 11:07:09 +0100	[thread overview]
Message-ID: <201201281107.09266.jdelvare@suse.de> (raw)

A udelay value of 20 leads to an I2C bus running at only 25 kbps. I2C
devices can typically operate faster than this, 50 kbps should be fine
for all devices (and compliant devices can always stretch the clock if
needed.)

FWIW, the vast majority of framebuffer drivers set udelay to 10
already. So set it to 10 in DRM drivers too, this will make EDID block
reads faster. We might even lower the udelay value later if no problem
is reported.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: Keith Packard <keithp@keithp.com>
Cc: Alex Deucher <alexdeucher@gmail.com>
---
Already sent on: 2011-10-21.

 drivers/gpu/drm/i915/intel_i2c.c    |    2 +-
 drivers/gpu/drm/radeon/radeon_i2c.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-3.3-rc1.orig/drivers/gpu/drm/i915/intel_i2c.c	2012-01-28 10:12:16.554480007 +0100
+++ linux-3.3-rc1/drivers/gpu/drm/i915/intel_i2c.c	2012-01-28 10:28:16.884668894 +0100
@@ -37,7 +37,7 @@
 
 /* Intel GPIO access functions */
 
-#define I2C_RISEFALL_TIME 20
+#define I2C_RISEFALL_TIME 10
 
 static inline struct intel_gmbus *
 to_intel_gmbus(struct i2c_adapter *i2c)
--- linux-3.3-rc1.orig/drivers/gpu/drm/radeon/radeon_i2c.c	2012-01-28 10:12:16.555480007 +0100
+++ linux-3.3-rc1/drivers/gpu/drm/radeon/radeon_i2c.c	2012-01-28 10:28:16.886668894 +0100
@@ -924,7 +924,7 @@ struct radeon_i2c_chan *radeon_i2c_creat
 		i2c->algo.bit.setscl = set_clock;
 		i2c->algo.bit.getsda = get_data;
 		i2c->algo.bit.getscl = get_clock;
-		i2c->algo.bit.udelay = 20;
+		i2c->algo.bit.udelay = 10;
 		/* vesa says 2.2 ms is enough, 1 jiffy doesn't seem to always
 		 * make this, 2 jiffies is a lot more reliable */
 		i2c->algo.bit.timeout = 2;

-- 
Jean Delvare
Suse L3

             reply	other threads:[~2012-01-28 10:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-28 10:07 Jean Delvare [this message]
2012-01-28 14:46 ` [PATCH 1/2] drm/kms: Make i2c buses faster Alex Deucher
2012-01-29  1:26 ` Keith Packard
2012-03-21 10:45   ` Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2011-10-21  7:08 Jean Delvare
2011-10-21 13:32 ` Alan Cox
2011-10-21 14:16   ` Jean Delvare
2011-10-21 18:05     ` Alex Deucher
2011-10-21 19:29       ` Jean Delvare
2011-10-22 14:38         ` Alex Deucher
2011-10-24 14:19           ` Eugeni Dodonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201281107.09266.jdelvare@suse.de \
    --to=jdelvare@suse.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eugeni.dodonov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.