All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Peter Hsiang <peter.hsiang@maxim-ic.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v2] ASoC: max98095: Convert codec->hw_write to snd_soc_write
Date: Sat, 22 Oct 2011 11:09:39 +0100	[thread overview]
Message-ID: <20111022100939.GA3727@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318650362.6399.1.camel@phoenix>

On Sat, Oct 15, 2011 at 11:46:02AM +0800, Axel Lin wrote:
> codec->hw_write is broken now, convert codec->hw_write to snd_soc_write.
> 
> The hardware has 2 banks of registers sharing a section in I2C register space.
> The 1st bank is the primary one and is cached.
> The 2nd bank is for loading coefficients only and they do not need cache.
> These coefficients registers are therefore direct writes.
> Thus we set cache_bypass flag to deal with this before calling snd_soc_write.

Applied, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Hsiang <peter.hsiang@maxim-ic.com>,
	Liam Girdwood <lrg@ti.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: max98095: Convert codec->hw_write to snd_soc_write
Date: Sat, 22 Oct 2011 11:09:39 +0100	[thread overview]
Message-ID: <20111022100939.GA3727@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318650362.6399.1.camel@phoenix>

On Sat, Oct 15, 2011 at 11:46:02AM +0800, Axel Lin wrote:
> codec->hw_write is broken now, convert codec->hw_write to snd_soc_write.
> 
> The hardware has 2 banks of registers sharing a section in I2C register space.
> The 1st bank is the primary one and is cached.
> The 2nd bank is for loading coefficients only and they do not need cache.
> These coefficients registers are therefore direct writes.
> Thus we set cache_bypass flag to deal with this before calling snd_soc_write.

Applied, thanks.

  reply	other threads:[~2011-10-22 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-15  3:46 [PATCH v2] ASoC: max98095: Convert codec->hw_write to snd_soc_write Axel Lin
2011-10-15  3:46 ` Axel Lin
2011-10-22 10:09 ` Mark Brown [this message]
2011-10-22 10:09   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111022100939.GA3727@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=peter.hsiang@maxim-ic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.