From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Grant Likely <grant@secretlab.ca>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: Provide a definition of struct gpio for the stub gpiolib
Date: Mon, 24 Oct 2011 14:07:06 +0200 [thread overview]
Message-ID: <20111024120706.GD6148@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111024120120.GO8708@ponder.secretlab.ca>
On Mon, Oct 24, 2011 at 02:01:20PM +0200, Grant Likely wrote:
> On Mon, Oct 24, 2011 at 01:27:29PM +0200, Mark Brown wrote:
> > This makes the stub gpio_request_array() much more usable as drivers can
> > declare struct gpio variables.
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Shouldn't this patch remove the definition from
> include/asm-generic/gpio.h at the same time?
Both the original forward declaration and the new definition are within
the !GPIOLIB case of the #defines, it's just a minimal patch moving the
undefined forward declaration to a defintion. I didn't want to worry
about reading the individual users to figure out if they had separate
defintions separately to the work to get them all moved over to gpiolib.
next prev parent reply other threads:[~2011-10-24 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 11:27 [PATCH] gpiolib: Provide a definition of struct gpio for the stub gpiolib Mark Brown
2011-10-24 12:01 ` Grant Likely
2011-10-24 12:07 ` Mark Brown [this message]
2011-10-24 12:54 ` Grant Likely
2011-10-24 13:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024120706.GD6148@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=grant@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.