From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress()
Date: Mon, 24 Oct 2011 20:48:35 +0200 [thread overview]
Message-ID: <20111024184835.88E101408E9B@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ3q-E9vDwZD1bri36emTWoDFUDDk5is_qoLcw=v3KDdzw@mail.gmail.com>
Dear Simon Glass,
In message <CAPnjgZ3q-E9vDwZD1bri36emTWoDFUDDk5is_qoLcw=v3KDdzw@mail.gmail.com> you wrote:
>
> IMHO we would be better off with a function call like
>
> ? ? ? ?show_boot_error(BOOTSTAGE_ID_RUN_OS);
>
> even if this is a macro. It is more explicit about the fact that we
> are reporting an error. Does that sound ok?
That's fine with me. [Just make sure we don't increase the code size.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the bathtub of history the truth is harder to hold than the soap,
and much more difficult to find ... - Terry Pratchett, _Sourcery_
next prev parent reply other threads:[~2011-10-24 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 18:40 [U-Boot] [RFC PATCH 0/2] bootstage: record and publish boot progress timing Simon Glass
2011-10-16 18:40 ` [U-Boot] [PATCH 1/2] Create an initial header for boot progress integers Simon Glass
2011-10-16 18:40 ` [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress() Simon Glass
2011-10-23 18:44 ` Wolfgang Denk
2011-10-24 1:48 ` Simon Glass
2011-10-24 18:48 ` Wolfgang Denk [this message]
2011-10-22 5:07 ` [U-Boot] [RFC PATCH 0/2] bootstage: record and publish boot progress timing Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024184835.88E101408E9B@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.