All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: error handling fix in
Date: Wed, 26 Oct 2011 08:00:51 +0000	[thread overview]
Message-ID: <20111026080051.GO31921@thunk.org> (raw)
In-Reply-To: <20111011134912.GB27127@elgon.mountain>

On Tue, Oct 11, 2011 at 04:49:12PM +0300, Dan Carpenter wrote:
> When allocated is unsiged it breaks the error handling at the end
> of the function when we call:
> 	allocated = ext4_split_extent(...);
> 	if (allocated < 0)
> 		err = allocated;
> 
> I've made it a signed int instead of unsigned.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

						- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: error handling fix in ext4_ext_convert_to_initialized()
Date: Wed, 26 Oct 2011 04:00:51 -0400	[thread overview]
Message-ID: <20111026080051.GO31921@thunk.org> (raw)
In-Reply-To: <20111011134912.GB27127@elgon.mountain>

On Tue, Oct 11, 2011 at 04:49:12PM +0300, Dan Carpenter wrote:
> When allocated is unsiged it breaks the error handling at the end
> of the function when we call:
> 	allocated = ext4_split_extent(...);
> 	if (allocated < 0)
> 		err = allocated;
> 
> I've made it a signed int instead of unsigned.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

						- Ted

  reply	other threads:[~2011-10-26  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 13:49 [patch] ext4: error handling fix in ext4_ext_convert_to_initialized() Dan Carpenter
2011-10-11 13:49 ` Dan Carpenter
2011-10-26  8:00 ` Ted Ts'o [this message]
2011-10-26  8:00   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111026080051.GO31921@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.