From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Michael Buesch" <mb@bu3sch.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
b43-dev <b43-dev@lists.infradead.org>,
wireless <linux-wireless@vger.kernel.org>
Subject: Switching ssb to read 8-bit quantities from SPROM
Date: Thu, 27 Oct 2011 06:59:11 +0200 [thread overview]
Message-ID: <20111027065911.43c6c49c@milhouse> (raw)
In-Reply-To: <4EA888AE.30406@lwfinger.net>
On Wed, 26 Oct 2011 17:24:46 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather
> than as 16-bit words in the manner that was just submitted for brcmsmac.
> Although this simplifies the calculation of the crc8, it only reduced the size
> of the module by 31 bytes, thus I will not be submitting the patch.
>
> When the library version of the crc8 routine was used rather than the one built
> into ssb, the size of the driver was increased by 17 bytes.
Well, if this doesn't cause regressions due to the changed reads, I'm OK
with it (as in I don't really care either way).
But it has to be tested on b44, too.
--
Greetings, Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Michael Buesch" <mb@bu3sch.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
b43-dev <b43-dev@lists.infradead.org>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Switching ssb to read 8-bit quantities from SPROM
Date: Thu, 27 Oct 2011 06:59:11 +0200 [thread overview]
Message-ID: <20111027065911.43c6c49c@milhouse> (raw)
In-Reply-To: <4EA888AE.30406@lwfinger.net>
On Wed, 26 Oct 2011 17:24:46 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather
> than as 16-bit words in the manner that was just submitted for brcmsmac.
> Although this simplifies the calculation of the crc8, it only reduced the size
> of the module by 31 bytes, thus I will not be submitting the patch.
>
> When the library version of the crc8 routine was used rather than the one built
> into ssb, the size of the driver was increased by 17 bytes.
Well, if this doesn't cause regressions due to the changed reads, I'm OK
with it (as in I don't really care either way).
But it has to be tested on b44, too.
--
Greetings, Michael.
next prev parent reply other threads:[~2011-10-27 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 22:24 Switching ssb to read 8-bit quantities from SPROM Larry Finger
2011-10-27 4:59 ` Michael Büsch [this message]
2011-10-27 4:59 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027065911.43c6c49c@milhouse \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.