All of lore.kernel.org
 help / color / mirror / Atom feed
* Joshua Lock : hob: fix backtrace when dismissing open dialog
@ 2011-10-27  7:09 git
  0 siblings, 0 replies; only message in thread
From: git @ 2011-10-27  7:09 UTC (permalink / raw)
  To: bitbake-devel

Module: bitbake.git
Branch: master
Commit: db59297aa1861614ffaea4295b9b054baa8a12b9
URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=db59297aa1861614ffaea4295b9b054baa8a12b9

Author: Joshua Lock <josh@linux.intel.com>
Date:   Tue Oct 11 10:16:02 2011 -0700

hob: fix backtrace when dismissing open dialog

Clearly a logic/indentation error - we should only try and load the recipe
should the file-chooser return OK.

Fixes [YOCTO #1668]

Signed-off-by: Joshua Lock <josh@linux.intel.com>

---

 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/ui/hob.py b/lib/bb/ui/hob.py
index 71ea88a..0fcaad5 100644
--- a/lib/bb/ui/hob.py
+++ b/lib/bb/ui/hob.py
@@ -400,9 +400,9 @@ class MainWindow (gtk.Window):
         if response == gtk.RESPONSE_OK:
             rep.loadRecipe(recipe)
             self.save_path = recipe
+            self.model.load_image_rep(rep)
+            self.dirty = False
         chooser.destroy()
-        self.model.load_image_rep(rep)
-        self.dirty = False
 
     def bake_clicked_cb(self, button):
         build_image = True




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-10-27  7:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-27  7:09 Joshua Lock : hob: fix backtrace when dismissing open dialog git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.