From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Warren <swarren@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/6] arm/tegra: implement support for tegra30
Date: Thu, 27 Oct 2011 21:24:49 +0100 [thread overview]
Message-ID: <20111027202449.GQ19187@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173E1B49B6@HQMAIL01.nvidia.com>
On Thu, Oct 27, 2011 at 01:10:10PM -0700, Stephen Warren wrote:
> Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM:
> > From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
> Some description here would be nice.
Definitely - it's something which Andrew Morton commented on during
the kernel summit. Commit messages really should sell the patch
they're attached to, so that people reading the kernel commit log
(a) have some idea what the patch is doing and (b) why it's being
added.
So maybe something like:
Add support for the Tegra T30 SoC, found in x, y and z. This
includes a device tree compatible type for this SoC ("nvidia,tegra30")
and adapts the kernels L2 cache initialization for this new SoC.
(That's my best guess based on the contents of this patch.)
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] arm/tegra: implement support for tegra30
Date: Thu, 27 Oct 2011 21:24:49 +0100 [thread overview]
Message-ID: <20111027202449.GQ19187@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173E1B49B6@HQMAIL01.nvidia.com>
On Thu, Oct 27, 2011 at 01:10:10PM -0700, Stephen Warren wrote:
> Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM:
> > From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
> Some description here would be nice.
Definitely - it's something which Andrew Morton commented on during
the kernel summit. Commit messages really should sell the patch
they're attached to, so that people reading the kernel commit log
(a) have some idea what the patch is doing and (b) why it's being
added.
So maybe something like:
Add support for the Tegra T30 SoC, found in x, y and z. This
includes a device tree compatible type for this SoC ("nvidia,tegra30")
and adapts the kernels L2 cache initialization for this new SoC.
(That's my best guess based on the contents of this patch.)
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Warren <swarren@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 4/6] arm/tegra: implement support for tegra30
Date: Thu, 27 Oct 2011 21:24:49 +0100 [thread overview]
Message-ID: <20111027202449.GQ19187@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173E1B49B6@HQMAIL01.nvidia.com>
On Thu, Oct 27, 2011 at 01:10:10PM -0700, Stephen Warren wrote:
> Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM:
> > From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
> Some description here would be nice.
Definitely - it's something which Andrew Morton commented on during
the kernel summit. Commit messages really should sell the patch
they're attached to, so that people reading the kernel commit log
(a) have some idea what the patch is doing and (b) why it's being
added.
So maybe something like:
Add support for the Tegra T30 SoC, found in x, y and z. This
includes a device tree compatible type for this SoC ("nvidia,tegra30")
and adapts the kernels L2 cache initialization for this new SoC.
(That's my best guess based on the contents of this patch.)
next prev parent reply other threads:[~2011-10-27 20:24 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 16:53 [PATCH 0/6] Add support for tegra30 and cardhu pdeschrijver-DDmLM1+adcrQT0dZR+AlfA
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
2011-10-25 16:53 ` [PATCH 1/6] arm/tegra: initial device tree for tegra30 pdeschrijver
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 19:45 ` Stephen Warren
2011-10-27 19:45 ` Stephen Warren
2011-10-27 19:45 ` Stephen Warren
2011-10-25 16:53 ` [PATCH 2/6] arm/tegra: prepare pinmux code for multiple tegra variants pdeschrijver
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-3-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 19:59 ` Stephen Warren
2011-10-27 19:59 ` Stephen Warren
2011-10-27 19:59 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF173E1B49AA-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-28 8:17 ` Peter De Schrijver
2011-10-28 8:17 ` Peter De Schrijver
2011-10-28 8:17 ` Peter De Schrijver
[not found] ` <20111028081738.GA12383-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2011-10-28 9:19 ` Olof Johansson
2011-10-28 9:19 ` Olof Johansson
2011-10-28 9:19 ` Olof Johansson
2011-10-28 16:18 ` Stephen Warren
2011-10-28 16:18 ` Stephen Warren
2011-10-28 16:18 ` Stephen Warren
2011-10-31 9:02 ` Peter De Schrijver
2011-10-31 9:02 ` Peter De Schrijver
[not found] ` <1319561644-6160-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-25 16:53 ` [PATCH 3/6] arm/tegra: prepare early init " pdeschrijver-DDmLM1+adcrQT0dZR+AlfA
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 20:06 ` Stephen Warren
2011-10-27 20:06 ` Stephen Warren
2011-10-27 20:06 ` Stephen Warren
2011-10-27 20:16 ` Russell King - ARM Linux
2011-10-27 20:16 ` Russell King - ARM Linux
2011-10-27 20:16 ` Russell King - ARM Linux
2011-10-28 16:19 ` Will Deacon
2011-10-28 16:19 ` Will Deacon
2011-10-28 16:19 ` Will Deacon
[not found] ` <20111028161933.GK23539-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2011-11-01 13:37 ` Peter De Schrijver
2011-11-01 13:37 ` Peter De Schrijver
2011-11-01 13:37 ` Peter De Schrijver
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF173E1B49B2-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-11-01 13:37 ` Peter De Schrijver
2011-11-01 13:37 ` Peter De Schrijver
2011-11-01 13:37 ` Peter De Schrijver
2011-10-25 16:53 ` [PATCH 4/6] arm/tegra: implement support for tegra30 pdeschrijver
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-5-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 20:10 ` Stephen Warren
2011-10-27 20:10 ` Stephen Warren
2011-10-27 20:10 ` Stephen Warren
2011-10-27 20:24 ` Russell King - ARM Linux [this message]
2011-10-27 20:24 ` Russell King - ARM Linux
2011-10-27 20:24 ` Russell King - ARM Linux
2011-10-25 16:53 ` [PATCH 5/6] arm/tegra: pinmux tables and definitions " pdeschrijver
2011-10-25 16:53 ` pdeschrijver
2011-10-25 16:53 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-6-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 20:18 ` Stephen Warren
2011-10-27 20:18 ` Stephen Warren
2011-10-27 20:18 ` Stephen Warren
2011-10-25 16:54 ` [PATCH 6/6] arm/tegra: add support for tegra30 based board cardhu pdeschrijver
2011-10-25 16:54 ` pdeschrijver
2011-10-25 16:54 ` pdeschrijver at nvidia.com
[not found] ` <1319561644-6160-7-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-10-27 20:22 ` Stephen Warren
2011-10-27 20:22 ` Stephen Warren
2011-10-27 20:22 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027202449.GQ19187@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.