All of lore.kernel.org
 help / color / mirror / Atom feed
* Christopher Larson : codeparser: make var_expands actually hold useful information
@ 2011-10-28  5:52 git
  0 siblings, 0 replies; only message in thread
From: git @ 2011-10-28  5:52 UTC (permalink / raw)
  To: bitbake-devel

Module: bitbake.git
Branch: master
Commit: 8e4e75383e43d6da2c16ec5286186a0d0569b0f8
URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=8e4e75383e43d6da2c16ec5286186a0d0569b0f8

Author: Christopher Larson <kergoth@gmail.com>
Date:   Thu Oct 27 22:45:04 2011 -0700

codeparser: make var_expands actually hold useful information

Previously, it was calling var_expands.update() rather than add(), with
a string argument, resulting in adding each character of that string to
the var_expands set, rather than the string itself.

Signed-off-by: Christopher Larson <kergoth@gmail.com>

---

 lib/bb/codeparser.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/bb/codeparser.py b/lib/bb/codeparser.py
index 83bbb92..0dd9a36 100644
--- a/lib/bb/codeparser.py
+++ b/lib/bb/codeparser.py
@@ -227,7 +227,7 @@ class PythonParser():
             elif self.compare_name(self.expands, node.func):
                 if isinstance(node.args[0], ast.Str):
                     self.warn(node.func, node.args[0])
-                    self.var_expands.update(node.args[0].s)
+                    self.var_expands.add(node.args[0].s)
                 elif isinstance(node.args[0], ast.Call) and \
                      self.compare_name(self.getvars, node.args[0].func):
                     pass




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-10-28  5:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-28  5:52 Christopher Larson : codeparser: make var_expands actually hold useful information git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.