From: Greg KH <gregkh@suse.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Miche Baker-Harvey <miche@google.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
Amit Shah <amit.shah@redhat.com>,
Anton Blanchard <anton@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] VirtioConsole support.
Date: Fri, 28 Oct 2011 18:27:59 +0200 [thread overview]
Message-ID: <20111028162759.GA27263@suse.de> (raw)
In-Reply-To: <20111027215535.GA5671@phenom.dumpdata.com>
On Thu, Oct 27, 2011 at 05:55:35PM -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 27, 2011 at 02:43:22PM -0700, Miche Baker-Harvey wrote:
> > Multiple HVC console terminals enabled.
>
> Miche,
>
> You might want to flesh out the description a bit. Perhaps include
> such details as : "fixes the infinite loop that git commit XX
> caused". Perhaps include some of the serial console output.
>
> Maybe also change the title - the patch name (which is what shows up
> if you do 'git log --oneline') is 'VirtioConsole support.' which is
> not very informative.
Yes, all of these need to be resolved before I can accept this.
thanks,
greg k-h
next prev parent reply other threads:[~2011-10-28 16:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 5:30 Regression: patch " hvc_console: display printk messages on console." causing infinite loop with 3.2-rc0 + Xen Konrad Rzeszutek Wilk
2011-10-27 5:34 ` Konrad Rzeszutek Wilk
2011-10-27 5:48 ` Greg KH
2011-10-27 14:45 ` Miche Baker-Harvey
2011-10-27 14:50 ` Fwd: " Miche Baker-Harvey
2011-10-27 15:08 ` Konrad Rzeszutek Wilk
2011-10-27 15:31 ` Konrad Rzeszutek Wilk
2011-10-27 17:22 ` Miche Baker-Harvey
2011-10-27 17:35 ` Konrad Rzeszutek Wilk
2011-10-27 18:39 ` [PATCH] VirtioConsole support Miche Baker-Harvey
2011-10-27 18:39 ` Miche Baker-Harvey
2011-10-27 21:15 ` Konrad Rzeszutek Wilk
2011-10-27 21:15 ` Konrad Rzeszutek Wilk
2011-10-31 9:55 ` Amit Shah
2011-10-31 9:55 ` Amit Shah
2011-10-27 21:43 ` Miche Baker-Harvey
2011-10-27 21:55 ` Konrad Rzeszutek Wilk
2011-10-27 21:55 ` Konrad Rzeszutek Wilk
2011-10-28 16:27 ` Greg KH [this message]
2011-10-28 16:27 ` Greg KH
2011-10-28 2:55 ` Joe Perches
2011-10-28 2:55 ` Joe Perches
2011-10-28 18:19 ` Stephen Boyd
2011-10-28 18:19 ` Stephen Boyd
2011-11-02 22:02 ` Rusty Russell
2011-11-02 22:02 ` Rusty Russell
2011-11-03 12:38 ` Christian Borntraeger
2011-11-03 12:38 ` Christian Borntraeger
2011-11-03 14:15 ` Konrad Rzeszutek Wilk
2011-11-03 14:15 ` Konrad Rzeszutek Wilk
2011-10-27 21:43 ` Miche Baker-Harvey
2011-11-02 1:13 ` Regression: patch " hvc_console: display printk messages on console." causing infinite loop with 3.2-rc0 + Xen Stephen Rothwell
2011-11-02 1:13 ` Stephen Rothwell
2011-11-02 1:13 ` Stephen Rothwell
2011-11-03 1:30 ` Greg KH
2011-11-03 1:30 ` Greg KH
2011-11-03 1:30 ` Greg KH
2011-11-07 6:19 ` Stephen Rothwell
2011-11-07 6:19 ` Stephen Rothwell
2011-11-07 6:19 ` Stephen Rothwell
2011-11-07 20:24 ` Greg KH
2011-11-07 20:24 ` Greg KH
2011-11-07 20:24 ` Greg KH
2011-10-31 7:48 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028162759.GA27263@suse.de \
--to=gregkh@suse.de \
--cc=amit.shah@redhat.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miche@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.